Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology: suite to workflow #238

Merged
merged 27 commits into from
Apr 28, 2021
Merged

Conversation

hjoliver
Copy link
Member

Partially address #83

See also #224

cylc-doc sibling of cylc/cylc-flow/pull/4174

@hjoliver hjoliver self-assigned this Apr 16, 2021
@hjoliver
Copy link
Member Author

Docs build locally 👍

@MetRonnie MetRonnie self-requested a review April 16, 2021 13:12
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self/Hilary: Did I see a reference to "Sceduler" somewhere?

src/glossary.rst Outdated Show resolved Hide resolved
src/reference/dev-history-major-changes.rst Outdated Show resolved Hide resolved
src/reference/dev-history-major-changes.rst Outdated Show resolved Hide resolved
src/reference/dev-history-major-changes.rst Outdated Show resolved Hide resolved
src/user-guide/installing-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/writing-workflows/external-triggers.rst Outdated Show resolved Hide resolved
src/user-guide/writing-workflows/jinja2.rst Outdated Show resolved Hide resolved
src/user-guide/writing-workflows/jinja2.rst Outdated Show resolved Hide resolved
src/user-guide/writing-workflows/jinja2.rst Outdated Show resolved Hide resolved
src/user-guide/writing-workflows/runtime.rst Outdated Show resolved Hide resolved
src/workflow-design-guide/portable-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/task-implementation/job-submission.rst Outdated Show resolved Hide resolved
src/workflow-design-guide/portable-workflows.rst Outdated Show resolved Hide resolved
src/user-guide/running-workflows.rst Outdated Show resolved Hide resolved
src/tutorial/scheduling/graphing.rst Outdated Show resolved Hide resolved
@hjoliver
Copy link
Member Author

Note to self/Hilary: Did I see a reference to "Sceduler" somewhere?

Yes, found it 👍

@hjoliver hjoliver requested a review from MetRonnie April 27, 2021 00:32
Comment on lines +675 to +676
.. TODO Suites -> Workflows once metomi cheat-sheet is updated

Copy link
Member

@oliver-sanders oliver-sanders Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect we will remove that cheat sheet, can use the new one in the migration guide and or add one at the top level.

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved notwithstanding merge conflicts

@@ -13,16 +13,13 @@ The :cylc:conf:`flow.cylc` File Format

.. ifnotslides::

We refer to a Cylc workflow as a :term:`Cylc suite`. A Cylc suite is a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

@oliver-sanders
Copy link
Member

Failing test is due to pending cylc-rose updates.

@oliver-sanders oliver-sanders merged commit 63dfb34 into cylc:master Apr 28, 2021
@hjoliver hjoliver deleted the suite-to-flow branch April 28, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants