document config upgrader #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
reviewed
Aug 24, 2021
Co-authored-by: Ronnie Dutta <[email protected]>
wxtim
commented
Aug 24, 2021
wxtim
commented
Aug 24, 2021
|
@MetRonnie Sorry about the speeling: 😞 |
MetRonnie
approved these changes
Aug 24, 2021
datamel
reviewed
Aug 25, 2021
|
@MetRonnie @datamel : Is it worth hanging onto this so that I can append a section about how Cylc 8 upgrades |
|
I've converted it to a draft on the basis you're going to add more stuff, feel free to un-draft when ready |
wxtim
force-pushed
the
document-config-upgrading
branch
from
cc61689 to
e92b49a
Compare
|
@MetRonnie @datamel Ready for re-review |
MetRonnie
reviewed
Aug 26, 2021
Co-authored-by: Ronnie Dutta <[email protected]> Co-authored-by: Melanie Hall <[email protected]>
datamel
approved these changes
Aug 27, 2021
wxtim
added a commit
to wxtim/cylc-doc
that referenced
this pull request
Sep 2, 2021
* document config upgrader * Apply suggestions from code review Co-authored-by: Ronnie Dutta <[email protected]> * sfsg * response to review * Apply suggestions from code review Co-authored-by: Ronnie Dutta <[email protected]> Co-authored-by: Melanie Hall <[email protected]> Co-authored-by: Ronnie Dutta <[email protected]> Co-authored-by: Melanie Hall <[email protected]>
wxtim
added a commit
to wxtim/cylc-doc
that referenced
this pull request
Sep 2, 2021
* document config upgrader * Apply suggestions from code review Co-authored-by: Ronnie Dutta <[email protected]> * sfsg * response to review * Apply suggestions from code review Co-authored-by: Ronnie Dutta <[email protected]> Co-authored-by: Melanie Hall <[email protected]> Co-authored-by: Ronnie Dutta <[email protected]> Co-authored-by: Melanie Hall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial answer to #170
Documents an example of what happens if you have Cylc6 stuff lying around, and wags a stern finger about upgrading deprecation warning config items before EOL next time.