-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0b3 installation changes #342
8.0b3 installation changes #342
Conversation
@@ -0,0 +1,8 @@ | |||
name: cylc-|release| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets replaced with the release when the file is read into the docs so we don't have to update it.
50e2699
to
09b8de7
Compare
0f303cb
to
885ca92
Compare
The "create conda environments" tests will fail at the moment because they are trying to create a Cylc 8.0rc1 environment (because Cylc Flow master is 8.0rc1). These tests will be a little flaky since they are trying to build environments for versions which have not necessarily been released yet. These tests will only run whenever these files are changed, on release, or on request (can manually set the cylc/python versions for the latter). Here's a run on my personal fork with the cylc-flow-version set to 8.0b3 (all passed): https://github.com/oliver-sanders/cylc-doc/runs/4327011989?check_suite_focus=true |
ac531e5
to
89a4fb1
Compare
* Update installation instructions. * Document Conda Forge package outputs. * Pin documented Conda environments to the Cylc "release" (i.e. minor version). * Update test workflow to create the new environments. * Add environment (and with it a test) for mixed Conda-Forge / Anaconda installations.
89a4fb1
to
01a3e4a
Compare
echo "# creating env from: ${env_file}" | ||
new_env_file="$(sed 's/\(.*\)\.yml/\1-2.yml/' <<< "${env_file}")" | ||
# substitute the python and cylc-flow versions in the env files | ||
# TODO: add explicit python dep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For another day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read - makes sense - I've put a couple of extremely minor suggestions down, nothing that wouldn't stop me approving.
- Built locally.
- Read built version.
- Would like to know if test failing because of absence of rc1 is deliberate or a mistake. -
Encountered problems while solving: - nothing provides requested cylc-flow 8.0rc1**
Co-authored-by: Tim Pillinger <[email protected]>
Explained by my comments above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems found by me.
@@ -6,7 +6,9 @@ | |||
.. _Cylc User Guide: https://cylc.github.io/cylc-doc/latest/html/index.html | |||
.. _Cylc Workflow Design Guide: https://cylc.github.io/cylc-doc/latest/html/workflow-design-guide/index.html | |||
.. _Cylc: https://cylc.github.io/ | |||
.. _Cylc 8 Discourse Support Group: https://cylc.discourse.group/c/cylc/7-to-8/13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that 13 is strange, although works nicely, just looks a bit odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discourse topic number? Dunno.
If you take it out of the URL, Discourse puts it back.
version).
installations.
Note: the conda tests are expected to fail at this stage, see the comment below and a link to a run where they pass.