Review feedback addressed from BK

cylc · Sep 1, 2020 · 84bdbc0 · 84bdbc0
1 parent 9b4bb88
commit 84bdbc0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cylc/flow/remote.py b/cylc/flow/remote.py
@@ -156,7 +156,7 @@ def construct_platform_ssh_cmd(raw_cmd, platform, **kwargs):
 
 
 def get_includes_to_rsync(rsync_includes=None):
-    """Returns a list of directories/files, configured in suite.rc,
+    """Returns a list of directories/files, configured in flow.cylc,
         to be included in the remote file installation.
     """
 

diff --git a/cylc/flow/suite_files.py b/cylc/flow/suite_files.py
@@ -87,7 +87,7 @@ def __init__(self, key_type, key_owner, full_key_path=None,
             if (key_owner is KeyOwner.CLIENT
                 and key_type is KeyType.PUBLIC
                     and self.install_target is not None):
-                file_name = file_name + f"_{self.install_target}"
+                file_name = f"{file_name}_{self.install_target}"
 
             if key_type == KeyType.PRIVATE:
                 file_extension = SuiteFiles.Service.PRIVATE_FILE_EXTENSION

diff --git a/tests/unit/test_config.py b/tests/unit/test_config.py
@@ -469,7 +469,7 @@ def test_rsync_includes_will_not_accept_sub_directories():
         includes = dir/, dir2/subdir2/, file1, file2
         """
     with TemporaryDirectory() as temp_dir:
-        suite_rc = Path(temp_dir, "suite.rc")
+        suite_rc = Path(temp_dir, "flow.cylc")
         with suite_rc.open(mode="w") as f:
             f.write(suiterc_content)
             f.flush()
@@ -493,7 +493,7 @@ def test_valid_rsync_includes_returns_correct_list():
         includes = dir/, dir2/, file1, file2
         """
     with TemporaryDirectory() as temp_dir:
-        suite_rc = Path(temp_dir, "suite.rc")
+        suite_rc = Path(temp_dir, "flow.cylc")
         with suite_rc.open(mode="w") as f:
             f.write(suiterc_content)
             f.flush()