Merge pull request #3409 from kinow/fix-ghissue-3097

Prevent cylc-run of creating directories for invalid suites

CHANGES.md

@@ -46,6 +46,11 @@ Third alpha release of Cylc 8.
 status message retries (problems that prevent message transmission are almost
 never transient, and in practice job polling is the only way to recover).
 
+### Fixes
+
+[#3409](https://github.com/cylc/cylc-flow/pull/3409) - prevent cylc-run from
+creating directories when executed for suites that do not exist.
+
 -------------------------------------------------------------------------------
 ## __cylc-8.0a1 (2019-09-18)__
 

cylc/flow/scheduler_cli.py

@@ -232,6 +232,13 @@ def scheduler_cli(parser, options, args, is_restart=False):
     except SuiteServiceFileError as exc:
         sys.exit(exc)
 
+    suite_run_dir = get_suite_run_dir(reg)
+
+    if not os.path.exists(suite_run_dir):
+        sys.stderr.write(f'suite service directory not found '
+                         f'at: {suite_run_dir}\n')
+        sys.exit(1)
+
     # Create auth files if needed.
     suite_files.create_auth_files(reg)
 

tests/cylc-run/01-invalid-suite.t

@@ -0,0 +1,29 @@
+#!/bin/bash
+# THIS FILE IS PART OF THE CYLC SUITE ENGINE.
+# Copyright (C) 2008-2019 NIWA & British Crown (Met Office) & Contributors.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#-------------------------------------------------------------------------------
+# Test that ``cylc-run`` does not create directories for invalid/not existent
+# suites. See https://github.com/cylc/cylc-flow/issues/3097 for more.
+. "$(dirname "$0")/test_header"
+#-------------------------------------------------------------------------------
+set_test_number 3
+#-------------------------------------------------------------------------------
+INVALID_SUITE_NAME="broken-parachute-8877-mp5"
+run_fail "${TEST_NAME_BASE}-run" cylc run "${INVALID_SUITE_NAME}"
+grep_ok "suite service directory not found at" "${TEST_NAME_BASE}-run.stderr"
+exists_fail "${HOME}/cylc-run/${INVALID_SUITE_NAME}"
+
+exit

tests/cylc-run/test_header

@@ -0,0 +1 @@
+../lib/bash/test_header