Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering runahead tasks causes workflow to finish early #4619

Closed
MetRonnie opened this issue Jan 27, 2022 · 2 comments · Fixed by #4640
Closed

Triggering runahead tasks causes workflow to finish early #4619

MetRonnie opened this issue Jan 27, 2022 · 2 comments · Fixed by #4640
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@MetRonnie
Copy link
Member

MetRonnie commented Jan 27, 2022

To reproduce:

[scheduler]
    allow implicit tasks = True
[scheduling]
    cycling mode = integer
    runahead limit = P3
    [[graph]]
        P1 = foo

When starting this workflow the first 3 cycles spawn and 4/foo is in the runahead state.

If you quickly trigger 4/foo while it is in runhead (before the other tasks have finished running), it will start running and when all tasks finish, the workflow shuts down (permanently finishes) even though there is no final cycle point.

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@oliver-sanders
Copy link
Member

I think I can see what's going on here.

@hjoliver
Copy link
Member

hjoliver commented Feb 2, 2022

This is related to how we auto-spawn next-instances of parentless tasks on release from runahead.

oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Feb 2, 2022
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Feb 2, 2022
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Feb 3, 2022
MetRonnie pushed a commit to MetRonnie/cylc-flow that referenced this issue Feb 3, 2022
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Feb 3, 2022
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
3 participants