cat-log: view retrieved remote logs locally. #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
force-pushed
the
cat-log-remote-local-view
branch
from
0c13640 to
77b120a
Compare
hjoliver
force-pushed
the
cat-log-remote-local-view
branch
from
77b120a to
43c5d2c
Compare
|
tests added |
bin/cylc-cat-log
Outdated
| Print, edit, or tail-follow content, or print path or list directory, of local | ||
| or remote task job logs and suite server logs. Batch-system-specific job cat or | ||
| tail commands are used if defined in global config. | ||
| Cat (print), edit, or tail-follow content, or print path or list directory, of |
There was a problem hiding this comment.
I think Print is actually more correct here.
The original Unix cat command does concatenate files and print on the standard output. Correct me if I am wrong, but I don't think this command actually does concatenate.
There was a problem hiding this comment.
I think unix cat is almost universally used to print a single file in practice - but fair point, you're right about it's origins and functionality. I'll correct the command help ... but this does suggest a bigger problem in that our command name is cylc cat-log!
| # Cat the remote one. | ||
| TEST_NAME=${TEST_NAME_BASE}-task-out | ||
| run_ok $TEST_NAME cylc cat-log -f o $SUITE_NAME a-task.1 | ||
| grep_ok '^the quick brown fox$' ${TEST_NAME}.stdout |
There was a problem hiding this comment.
Need to run purge_suite to tidy up.
| # Cat the local one. | ||
| TEST_NAME=${TEST_NAME_BASE}-out-loc | ||
| run_ok $TEST_NAME cylc cat-log -f o $SUITE_NAME a-task.1 | ||
| grep_ok '^the quick brown FOX$' ${TEST_NAME}.stdout |
There was a problem hiding this comment.
Need to run purge_suite to tidy up.
sadielbartholomew
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small follow-up to #2503, to avoid unnecessary ssh connections. Current cat-log tests all pass on this branch with log retrieval or not configured in
global-tests.rc, but before requesting review I'll add another test to distinguish the two cases.