Contributor agreement and copyright update. #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the italicised sentence in CONTRIBUTING.md - I think that should be a sufficient measure for "backward compatibility", no? |
hjoliver
force-pushed
the
contributors
branch
5 times, most recently
from
ef11f34 to
40ec386
Compare
|
(Discussing the exact wording offline.) |
|
Failing the code style test! |
|
Doh. Fixed. |
dpmatthews
reviewed
Jul 18, 2018
CONTRIBUTING.md
Outdated
| The following people have contributed to this code under the terms of | ||
| the Contributor Licence Agreement and Certificate of Origin detailed | ||
| below (_except for the parenthesised names, which represent contributions | ||
| from outside of NIWA and Met Office that predate the explicit introduction of |
There was a problem hiding this comment.
Should be "the Met Office"
|
(Done - also in in-source Copyright file-headers) |
|
Better to leave it out of the copyright notices - e.g. we don't have it Rose. |
|
You're hard to please today! Try it for size now. |
matthewrmshin
approved these changes
Jul 18, 2018
|
Not sure I want to cherry pick this one. Does it need to go to 7.7.2? |
|
Good point. Change it to 7.8.0. It's on master now, so new contributors will still need to agree to it anyway. |
|
(changed milestone) |
10 tasks
sadielbartholomew
added a commit
to sadielbartholomew/cylc-flow
that referenced
this pull request
Jul 19, 2018
sadielbartholomew
added a commit
to sadielbartholomew/cylc-flow
that referenced
this pull request
Jul 19, 2018
sadielbartholomew
added a commit
to sadielbartholomew/cylc-flow
that referenced
this pull request
Jul 19, 2018
sadielbartholomew
added a commit
to sadielbartholomew/cylc-flow
that referenced
this pull request
Sep 14, 2018
kinow
pushed a commit
to kinow/cylc-flow
that referenced
this pull request
Oct 18, 2018
kinow
pushed a commit
to kinow/cylc-flow
that referenced
this pull request
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One for you @dpmatthews!