Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cylc version, dropping VERSION file and git info #3001

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Simplify cylc version, dropping VERSION file and git info #3001

merged 4 commits into from
Mar 14, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Mar 13, 2019

Fix for #2997

  • The cylc.version module has been deleted
  • To minimize changes, instead of using __version__, I did a from cylc import __version__ as CYLC_VERSION
  • Documentation updates were minimal, as most of the rest appears to be related to how Cylc is installed from .tar.gz or git. Both should be replaced by setup.py in Make cylc a module #2990 later, where we will discuss ways to install Cylc (Conda, RPM, pip, etc)
  • Fixed make-tarball, even though I realized it can be removed as part of Make cylc a module #2990

This is a blocker for #2991 as we need this to change how the profile-battery works too.

@kinow kinow added this to the cylc-8-alpha-1 milestone Mar 13, 2019
@kinow kinow requested review from hjoliver and matthewrmshin March 13, 2019 22:16
@kinow kinow self-assigned this Mar 13, 2019
hjoliver
hjoliver approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good (one trivial change requested). 👍

etc/dev-bin/make-tarball Outdated Show resolved Hide resolved
@kinow kinow force-pushed the simplify-cylc-version branch from 7a5511a to 26091ec Compare March 13, 2019 23:49
matthewrmshin
matthewrmshin suggested changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the version string to the PEP440 compliant syntax.

All other changes are good.

lib/cylc/__init__.py Outdated Show resolved Hide resolved
@kinow
Copy link
Member Author

kinow commented Mar 14, 2019

Version changed @matthewrmshin . Thanks!

@matthewrmshin matthewrmshin merged commit c3d669e into cylc:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewrmshin matthewrmshin matthewrmshin approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@kinow kinow

Labels
None yet
Projects
None yet
Milestone
cylc-8.0a1
Development

Successfully merging this pull request may close these issues.
3 participants
@kinow @matthewrmshin @hjoliver