Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless license commands. #3091

Merged
merged 1 commit into from
Apr 7, 2019

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Apr 7, 2019

Address two #1249 check-list items.

Remove cylc warranty and cylc conditions, which just printed information held in the COPYING file.

@hjoliver hjoliver added the small label Apr 7, 2019
@hjoliver hjoliver added this to the cylc-8.0a1 milestone Apr 7, 2019
@hjoliver hjoliver self-assigned this Apr 7, 2019
@hjoliver hjoliver requested a review from kinow April 7, 2019 23:12
@hjoliver hjoliver force-pushed the remove-useless-lic-commands branch from cf49254 to ce9979e Compare April 7, 2019 23:15
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never paid attention to bin/cylc-conditions, I would have missed that one! Looks great, LGTM! Just depends on Travis being help with the changes, of course. Another great thing about all these recent pull requests to remove outdated stuff, is that some functional tests are going away with the changes too. Which means our tests will a bit faster in Travis 🎉

@hjoliver
Copy link
Member Author

hjoliver commented Apr 7, 2019

(Second review not required for this trivial change).

@hjoliver hjoliver merged commit 647c992 into cylc:master Apr 7, 2019
@hjoliver hjoliver deleted the remove-useless-lic-commands branch April 7, 2019 23:31
@hjoliver hjoliver mentioned this pull request Apr 7, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants