Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright notices for setup (& other) files #3310

Merged

Conversation

sadielbartholomew
Copy link
Collaborator

Whilst looking at the cylc-xtriggers repo I noticed the setup script had a copyright notice that did not include this year (cylc/cylc-xtriggers#5). Since the likelihood is that one template for these scripts was copied across repos & amended accordingly, I thought I would check that similar files in other repos were up-to-date.

In this case, it was not, & there were also three other instances remaining of outdated notices from a git grep "\-2018" (& the equivalent with a few other preceding years).

Trivial change, hence one reviewer sufficient.

This is a small change with no associated Issue.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (reason: non-functional).
  • No change log entry required (reason: invisible to users).
  • No documentation update required.

@sadielbartholomew sadielbartholomew added this to the cylc-8.0a1 milestone Aug 24, 2019
@sadielbartholomew sadielbartholomew self-assigned this Aug 24, 2019
@sadielbartholomew sadielbartholomew changed the title Update copyright notices for setuptools (& other) files Update copyright notices for setup (& other) files Aug 24, 2019
@kinow
Copy link
Member

kinow commented Aug 24, 2019

Approved and will merge in a minute. First will just look at travis failures to see if we need to update the flaky tests list.

Thanks Sadie!

@kinow
Copy link
Member

kinow commented Aug 24, 2019

Tests that failed:

  • ./tests/restart/23-hold-retry.t
  • ./tests/hold-release/12-hold-then-retry.t

I was going to update #2894, but realized that #3286 includes changes for these two tests. So I am assuming it will be just fixed once that one is merged 🎉

Merging!

@kinow kinow merged commit 5eb5245 into cylc:master Aug 24, 2019
@sadielbartholomew sadielbartholomew deleted the update-setuptools-file-copyright branch August 24, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants