Fix global UTC mode bug #3632
Fix global UTC mode bug #3632
Conversation
| # Running in UTC time? (else just use the system clock) | ||
| if self.cfg['cylc']['UTC mode'] is None: | ||
| set_utc_mode(glbl_cfg().get(['cylc', 'UTC mode'])) | ||
| else: | ||
| set_utc_mode(self.cfg['cylc']['UTC mode']) |
There was a problem hiding this comment.
Actually, it seems to me that instead of manually getting the global config defaults with glbl_cfg().get(), this ought to be taken care of in self.pcfg.get(sparse=False), i.e. when expanding the config dict, which currently only takes the suite config defaults?
There was a problem hiding this comment.
Is the default not coming through as expected?
There was a problem hiding this comment.
Yes, with this bug fix the default is coming through. I just meant that when loading the dense/sparse=False config (expanded with the suite defaults), it might be better if it also loaded the global defaults as well. I had a look at it but it doesn't look straightforward
There was a problem hiding this comment.
Yeah, parsec is a bit of a here be dragons, venture if ye dare.
There was a problem hiding this comment.
The suite / global distinction is a necessary one though, in the Cylc9 timeframe we might be able to do something nicer but ATM I think it's the way it needs to be.
E.G. we want to be able to reload the global configuration whilst the suite is running but not the suite configuration.
It would be very nice if we had one, simple object which handled the suite/global abstraction for us, has a memory efficient tiered structure, which linked into the SPEC and behaves like a nice simple dictionary.
There was a problem hiding this comment.
Yeah, parsec is a bit of a here be dragons, venture if ye dare.
Argh, my fault! (but, back in the day, it was twice as fast as its predecessor!)
- Cycle points now obey value specified in global config - Default `False` no longer overrides value specified in global config
|
The tests that really should have been included with this are in #3614 |
Falseno longer overrides value specified in global config fileThese changes close #3631
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.