Make obsolete [runtime][][remote]suite definition directory
#4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
conf.remove-suite-definition-directory
branch
2 times, most recently
from
f790097 to
90286ec
Compare
wxtim
changed the title
[runtime][][remote]suite definition directory
remove CYLC_SUITE_DEF_PATH & CYLC_SUITE_DEF_PATH_ON_SUITE_HOST Make unit test easier to debug by reading the result to be tested to memory. Fix a number of functional tests broken (mission creep).
wxtim
force-pushed
the
conf.remove-suite-definition-directory
branch
from
90286ec to
4010a7e
Compare
MetRonnie
reviewed
Mar 17, 2021
MetRonnie
approved these changes
Mar 17, 2021
oliver-sanders
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes partially address #3696 : They are the last config change on the checklist there. 🎉
That is:
flow.cylc:[runtime][__TASK__][remote]suite definition directory(But not the similar platform item fromglobal.cylc).Additionally I fixed a few tests broken by the change of default behavior to preventing implicit tasks. (@MetRonnie Please extra double check these.)
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.