-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state totals fixes #4173
state totals fixes #4173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the UI, on master
got the states with different values than the ones displayed in the tree view, and also some weird state for the toolbar.
With this PR, the toolbar behaves correctly, and the states in GScan and in the tree view are matching. Great job @dwsutherland !
Got the issue I had seen on Will leave it to @oliver-sanders to finish the review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍾
These changes close #4157
![image](https://user-images.githubusercontent.com/11400777/114799750-770b3d00-9dec-11eb-91f8-34edc94e84b2.png)
Also fixes incorrect state totals (caused by only the deltas, and not the store totals, being collected).
Although I have noticed additional
succeeded
every now and then, which I will hunt down eventually but is only visible in TUI.Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.