Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent platforms and groups sharing names #4445

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Prevent platforms and groups sharing names #4445

merged 5 commits into from
Oct 5, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 1, 2021 •
edited
Loading

These changes close #4434

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • (master branch) I have added to a documentation PR at added a guide to writing a platform configuration. cylc-doc#289

@wxtim wxtim self-assigned this Oct 1, 2021
@wxtim wxtim added this to the cylc-8.0rc1 milestone Oct 1, 2021
@wxtim wxtim added could be better Not exactly a bug, but not ideal. platforms-follow-up labels Oct 1, 2021
@oliver-sanders
Copy link
Member

Looks good, doctests unhappy for some reason, giving them a poke...

datamel
datamel approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out and tested as working. Thanks @wxtim!

@datamel datamel merged commit 6066648 into cylc:master Oct 5, 2021
@MetRonnie MetRonnie modified the milestones: cylc-8.0rc1, cylc-8.0b3 Oct 7, 2021
@wxtim wxtim deleted the prevent_platforms_and_groups_sharing_names branch March 22, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@datamel datamel datamel approved these changes

Assignees

@wxtim wxtim

Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Milestone
cylc-8.0b3
Development

Successfully merging this pull request may close these issues.

conf: validate platform groups
4 participants
@wxtim @oliver-sanders @datamel @MetRonnie