Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VCS info file format to JSON #4548

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Dec 7, 2021

These changes close #4546

Change the workflow version control info file format from modified INI to JSON. This is still easily human readable but is much easier to parse by programs that can't use parsec (e.g. see metomi/rose#2520).

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included
  • Appropriate change log entry included.
  • No documentation update required (updated the relevant auto-doc material)

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - do you want me to fix rose, or do you want to do it?

@MetRonnie
Copy link
Member Author

metomi/rose#2520

@oliver-sanders oliver-sanders merged commit 6b27df8 into cylc:master Dec 8, 2021
@MetRonnie MetRonnie deleted the vcs branch December 8, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider format of version control log fille
3 participants