Fix xtrigger sequential arg validation & improve docs
#6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(LGTM) |
MetRonnie
force-pushed
the
xtrig-sequential
branch
from
1f38e52 to
d37c060
Compare
MetRonnie
force-pushed
the
xtrig-sequential
branch
from
d37c060 to
94bdb32
Compare
cylc/flow/dbstatecheck.py
Outdated
| @@ -84,8 +84,16 @@ def __init__(self, rund, workflow, db_path=None): | |||
| self.db_point_fmt = self._get_db_point_format_compat() | |||
| self.c7_back_compat_mode = True | |||
| except sqlite3.OperationalError: | |||
| self.conn.close() | |||
There was a problem hiding this comment.
Consider using with suppress(Exception) on this close if raising the original source of the OperationalError is likely to make more sense as an error.
There was a problem hiding this comment.
(merge if you don't think this is relevant)
oliver-sanders
approved these changes
Jun 17, 2024
If you don't close DB connections when you're done with them, I will scream
MetRonnie
force-pushed
the
xtrig-sequential
branch
from
94bdb32 to
0393a03
Compare
|
(MacOS test cancellations are macos-11 runner brownouts) |
|
Merging with Oliver's review suggestion force-pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on/needs:
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.