Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run mode skip to cylc show #6554

Open
wants to merge 6 commits into
base: 8.4.x
Choose a base branch
from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 13, 2025

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • Very, very small feature.

@wxtim wxtim force-pushed the feat.skip_shown_in_cylc_show branch from 04bd7b1 to b01e496 Compare January 13, 2025 15:37
@wxtim wxtim changed the base branch from master to 8.4.x January 13, 2025 15:37
@wxtim wxtim self-assigned this Jan 13, 2025
@wxtim wxtim added the could be better Not exactly a bug, but not ideal. label Jan 13, 2025
@@ -346,9 +347,15 @@ async def prereqs_and_outputs_query(
attrs.append("queued")
if t_proxy['isRunahead']:
attrs.append("runahead")
if (
t_proxy['runtime']['runMode']
and t_proxy['runtime']['runMode'] == 'Skip'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the RunMode enum?

cylc/flow/scripts/show.py Outdated Show resolved Hide resolved
@MetRonnie MetRonnie marked this pull request as draft January 13, 2025 16:07
@wxtim wxtim requested a review from oliver-sanders January 15, 2025 11:54
@wxtim wxtim marked this pull request as ready for review January 15, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants