cylc-pause: change held->paused #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
reviewed
Mar 18, 2021
|
Got the e2e almost all passing now, will push a commit to your branch @oliver-sanders 👍 |
kinow
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
CI passing. @oliver-sanders do we need to wait for the cylc-flow PR? Maybe because of the workflow state enum change, as I think GScan wouldn't know which icon to display for held state?
|
Thanks @kinow, wake up in the morning and the tests are fixed! Yes, should wait for the cylc-flow PR but that should be going in very soon. |
|
Done cylc/cylc-flow#4076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to cylc/cylc-flow#4076
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.