-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Cylc object ID, type and status at top of mutations menu #891
Conversation
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
- Coverage 90.48% 90.30% -0.19%
==========================================
Files 92 92
Lines 1986 2000 +14
Branches 146 151 +5
==========================================
+ Hits 1797 1806 +9
- Misses 162 168 +6
+ Partials 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read, seems sane.
- Tried, works for me.
Not entirely nice if users make task names very long - discussed in person.
Also reduce font size of Cylc object name
53606b4
to
4acef2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with your response to my review comment. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These changes close #769
Show the task/job/cycle/workflow ID, type and state at the top of the mutations menu (or just that alone if the object doesn't have a mutations menu)
Not sure how to write a test for this
Screenshots
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.Also to do:
v-cylc-object
directive