Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Cylc object ID, type and status at top of mutations menu #891

Merged
merged 8 commits into from
Feb 2, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jan 24, 2022

These changes close #769

Show the task/job/cycle/workflow ID, type and state at the top of the mutations menu (or just that alone if the object doesn't have a mutations menu)

Not sure how to write a test for this

Screenshots


Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

Also to do:

@MetRonnie MetRonnie added this to the 1.0 milestone Jan 24, 2022
@MetRonnie MetRonnie self-assigned this Jan 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #891 (0c99038) into master (5858614) will decrease coverage by 0.18%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
- Coverage   90.48%   90.30%   -0.19%     
==========================================
  Files          92       92              
  Lines        1986     2000      +14     
  Branches      146      151       +5     
==========================================
+ Hits         1797     1806       +9     
- Misses        162      168       +6     
+ Partials       27       26       -1     
Flag Coverage Δ
e2e 76.45% <71.42%> (-0.09%) ⬇️
unittests 78.25% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/cylc/table/Table.vue 77.27% <ø> (ø)
src/components/cylc/tree/TreeItem.vue 100.00% <ø> (ø)
src/components/cylc/workflow/Toolbar.vue 73.07% <ø> (ø)
src/components/cylc/cylcObject/Menu.vue 75.86% <57.14%> (-5.96%) ⬇️
src/components/cylc/cylcObject/plugin.js 100.00% <100.00%> (ø)
.../components/graphqlFormGenerator/FormGenerator.vue 86.95% <100.00%> (+4.34%) ⬆️
src/utils/aotf.js 93.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5858614...0c99038. Read the comment docs.

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read, seems sane.
  • Tried, works for me.

Not entirely nice if users make task names very long - discussed in person.

@MetRonnie
Copy link
Member Author

Not entirely nice if users make task names very long

  • Reduced font size of object ID title
  • Set max width of 600px for mutations menu

@MetRonnie
Copy link
Member Author

Mobile view (iPhone SE size)

@wxtim wxtim self-requested a review January 31, 2022 10:27
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with your response to my review comment. :)

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjoliver hjoliver merged commit 7564da1 into cylc:master Feb 2, 2022
@MetRonnie MetRonnie deleted the cylc-object-info branch February 2, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ideas for improving the tree view
4 participants