mkdirall: switch to os.FileMode argument #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a cosmetic change for most users, but libpathrs uses os.FileMode as well and most Go users are more used to using os.FileMode. The only thing that users need to watch out for is that they need to switch from unix.S_ISVTX to os.ModeSticky if they are using that bit (since os.FileMode and unix.S_* bits have a different layout). This will also help with building on 32-bit architectures without switching the argument type to uint32 explicitly. Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
mkdirall-os-filemode
branch
from
208d7f3 to
0c2fbe6
Compare
|
@kolyshkin WDYT? For runc all of the uses just directly pass |
cyphar
force-pushed
the
mkdirall-os-filemode
branch
from
17854d7 to
428c39e
Compare
Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
mkdirall-os-filemode
branch
from
428c39e to
ea4e5b6
Compare
kolyshkin
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
To me either way is fine, as long as it is documented, but I guess most users
- do not know that some of the
os.Mode*bit values differ from their low-levelunix.S_*counterparts; - do expect high-level
os.Mode*values to be passed toMkdir*functions.
So I think this change is indeed an improvement, LGTM.
|
Thanks for the review, I agree! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a cosmetic change for most users, but libpathrs uses
os.FileMode as well and most Go users are more used to using
os.FileMode. The only thing that users need to watch out for is that
they need to switch from unix.S_ISVTX to os.ModeSticky if they are using
that bit (since os.FileMode and unix.S_* bits have a different layout).
This will also help with building on 32-bit architectures without
switching the argument type to uint32 explicitly.
Closes #34
Signed-off-by: Aleksa Sarai [email protected]