[FIX] Disable by default delivery receipt in compose form #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaninyumu1
force-pushed
the
Cypht-read-receipts-make-the-feature-optional-default-off
branch
5 times, most recently
from
32b4457 to
61159be
Compare
josaphatim
changed the title
josaphatim
reviewed
May 14, 2024
| @@ -1133,7 +1133,7 @@ protected function output() { | |||
| '<textarea id="compose_body" name="compose_body" class="compose_body form-control" placeholder="'.$this->trans('Message').'">'.$this->html_safe($body).'</textarea>'. | |||
| (!$html ? '<label for="compose_body">'.$this->trans('Message').'</label>': ''). | |||
| '</div>'. | |||
| '<div class="form-check mb-3"><input value="1" name="compose_delivery_receipt" id="compose_delivery_receipt" type="checkbox" class="form-check-input" /><label for="compose_delivery_receipt" class="form-check-label">'.$this->trans('Request a delivery receipt').'</label></div>'; | |||
| '<div class="form-check mb-3"><input value="0" name="compose_delivery_receipt" id="compose_delivery_receipt" type="checkbox" class="form-check-input" /><label for="compose_delivery_receipt" class="form-check-label">'.$this->trans('Request a delivery receipt').'</label></div>'; | |||
There was a problem hiding this comment.
@amaninyumu1 This is the only one change needed here. Can you remove others before we merge ?
There was a problem hiding this comment.
I think because I modified the default values of the checkbox from 1 to 0
There was a problem hiding this comment.
I made some changes please review
amaninyumu1
force-pushed
the
Cypht-read-receipts-make-the-feature-optional-default-off
branch
from
61159be to
c6bb6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues