Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added functionality : query the user's repositories and add them to the user settings on github connect #1086

Merged
merged 2 commits into from
Jul 6, 2024
Merged

added functionality : query the user's repositories and add them to the user settings on github connect #1086

merged 2 commits into from
Jul 6, 2024

Conversation

David-Muhasa
Copy link
Contributor

…the user settings on github connect

Pullrequest

Issues

  • None

Checklist

  • None

How2Test

  • None

Todo

  • None

@David-Muhasa David-Muhasa changed the title added functionality : query the user's repositories and add them to … Automatically add user github repositories on connect Jun 14, 2024
@David-Muhasa
Copy link
Contributor Author

added functionality : query the user's repositories and add them to the user settings on github connect
#332

josaphatim
josaphatim reviewed Jun 19, 2024
View reviewed changes
modules/github/modules.php Outdated Show resolved Hide resolved
modules/github/modules.php Outdated Show resolved Hide resolved
modules/github/modules.php Show resolved Hide resolved
marclaporte
marclaporte reviewed Jun 20, 2024
View reviewed changes
lib/framework.php Outdated Show resolved Hide resolved
@David-Muhasa David-Muhasa changed the title Automatically add user github repositories on connect added functionality : query the user's repositories and add them to the user settings on github connect Jun 24, 2024
@marclaporte marclaporte requested a review from Yannick243 June 24, 2024 12:06
@David-Muhasa David-Muhasa force-pushed the user-repositories branch 2 times, most recently from a780eef to bb03821 Compare June 25, 2024 12:14
@josaphatim josaphatim force-pushed the user-repositories branch 3 times, most recently from d4ade04 to 830037b Compare June 27, 2024 21:10
@Yannick243
Copy link
Member

Hello @josaphatim
After completing the authorization process on GitHub (during the callback), Cypht's authentication logs out, forcing the user to log in again. Have you encountered this behavior elsewhere or do you have any suggestions on how to resolve it ?

@josaphatim
Copy link
Member

GMAIL_CLIENT_URI must point to ?page=home

for example: GMAIL_CLIENT_URI=http://localhost/cypht/?page=home

@Yannick243
Copy link
Member

Yannick243 commented Jul 1, 2024 •
edited
Loading

GMAIL_CLIENT_URI must point to ?page=home

for example: GMAIL_CLIENT_URI=http://localhost/cypht/?page=home

This doesn't seem to work, the user is still logged out
Any other idea ?

@josaphatim
Copy link
Member

GMAIL_CLIENT_URI must point to ?page=home
for example: GMAIL_CLIENT_URI=http://localhost/cypht/?page=home

This doesn't seem to work, the user is still logged out Any other idea ?

Sorry it is GITHUB_REDIRECT_URI=http://localhost/cypht/?page=home

@Yannick243
Copy link
Member

GITHUB_REDIRECT_URI

This is what i used

@Yannick243 Yannick243 merged commit 1bd9fd8 into cypht-org:master Jul 6, 2024
2 of 5 checks passed
@Yannick243 Yannick243 mentioned this pull request Jul 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josaphatim josaphatim josaphatim left review comments

@marclaporte marclaporte marclaporte left review comments

@Yannick243 Yannick243 Awaiting requested review from Yannick243

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@David-Muhasa @Yannick243 @josaphatim @marclaporte