Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]Add a way to be able to deactivate 'delete attachment' #1087

Merged
merged 3 commits into from
Jul 31, 2024
Merged

[ENH]Add a way to be able to deactivate 'delete attachment' #1087

merged 3 commits into from
Jul 31, 2024

Conversation

Baraka24
Copy link
Member

[ENH]Setting: Add a way to be able to deactivate 'delete attachment'

@Baraka24 Baraka24 marked this pull request as draft June 14, 2024 21:58
@Baraka24 Baraka24 force-pushed the disable_delete_attachment_setting branch from ee034c0 to 0331d2f Compare June 15, 2024 22:42
@Baraka24 Baraka24 marked this pull request as ready for review June 15, 2024 22:42
@Baraka24 Baraka24 force-pushed the disable_delete_attachment_setting branch from 0331d2f to 39588ff Compare June 17, 2024 21:48
@marclaporte marclaporte requested a review from Shadow243 July 11, 2024 18:18
Shadow243
Shadow243 requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to remove the attachement, it's not removing, but it redirect to http://cypht.test/?&imap_msg_part=0.2 check the url again please.

modules/imap/functions.php Show resolved Hide resolved
@Baraka24 Baraka24 force-pushed the disable_delete_attachment_setting branch from 39588ff to 5075a51 Compare July 28, 2024 09:13
@Baraka24
Copy link
Member Author

When trying to remove the attachement, it's not removing, but it redirect to http://cypht.test/?&imap_msg_part=0.2 check the url again please.

Thanks, I did not figure out this, I shall work on it and come back to you.

@cypht-org cypht-org deleted a comment from Baraka24 Jul 29, 2024
@josaphatim josaphatim force-pushed the disable_delete_attachment_setting branch from 5075a51 to d90cb90 Compare July 30, 2024 17:04
@Baraka24
Copy link
Member Author

Hello @Shadow243, this is ready now, @josaphatim has been fixing redirection while removing attachment.

Shadow243
Shadow243 requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@Shadow243 Shadow243 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Stalwart and it's working. Just this last correction and it's fine.

modules/core/setup.php Outdated Show resolved Hide resolved
@Shadow243 Shadow243 merged commit 038a0da into cypht-org:master Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclaporte marclaporte marclaporte left review comments

@Shadow243 Shadow243 Shadow243 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Baraka24 @marclaporte @Shadow243