[FIX]Profiles: Fix duplicated profile for the same email adress #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow243
requested changes
Jul 25, 2024
Baraka24
force-pushed
the
fix_duplicated_profile_for_same_smtp
branch
from
3958a49 to
1732109
Compare
Baraka24
changed the title
Shadow243
requested changes
Jul 25, 2024
Baraka24
force-pushed
the
fix_duplicated_profile_for_same_smtp
branch
from
1732109 to
c2dc987
Compare
|
@Shadow243 Thanks for a kind review, I did not figure out some points, you make them clear to me and I applied changes. |
Perfect. What about 'replyto' ? I think we can add OR in that condition. What do you think about that? The idea is to prevent duplication with 'replyto' field. |
Baraka24
force-pushed
the
fix_duplicated_profile_for_same_smtp
branch
from
c2dc987 to
1b078b7
Compare
Adding the 'replyto' field to the condition makes sense as we want to ensure that no profiles are duplicated based on the 'replyto' field as well. |
Baraka24
force-pushed
the
fix_duplicated_profile_for_same_smtp
branch
from
1b078b7 to
e936db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue