Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed phpunit broken test #1100

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

josaphatim
Copy link
Member

@josaphatim josaphatim commented Jun 21, 2024

Follow up to #1099 to fix access to $imap_details when no imap auth server and also unit test

@josaphatim josaphatim force-pushed the fix-undefined-vars branch from be21163 to a2d5aa5 Compare June 21, 2024 10:23
@josaphatim josaphatim changed the title Fixed undefined variable when no IMAP auth Fixed phpunit broken test Jun 21, 2024
@josaphatim josaphatim requested a review from kroky June 21, 2024 10:25
Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually trying to solve the same thing.

tests/phpunit/config.php Show resolved Hide resolved
@josaphatim josaphatim merged commit eac34f6 into cypht-org:master Jul 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants