[FIX] I fixed a PHP Warning added a condition to check if ->get('rec…

[amaninyumu1]

No description provided.

[Shadow243]

@amaninyumu1 Can you describe the scenario please !

[amaninyumu1]

Hello @Shadow243.

[amaninyumu1]

Hello @Shadow243
The problem was that we were trying to use $this->get('recaptcha_config') without being able to check if it exists. So I added a condition to check if it exists and then use it

[Shadow243]

According to https://github.com/cypht-org/cypht/blob/master/modules/recaptcha/setup.php#L8 $this->get('recaptcha_config') will never be undefined, did you get an issue about it ?

The file https://github.com/cypht-org/cypht/blob/master/modules/recaptcha/recaptcha.ini should be removed as well.

[amaninyumu1]

Yes but in this scenario the error was that the "recaptcha_config" key is null so it was impossible to access array offset on value of type null which is why I checked if it exists. In case it exists then it is not null

[Shadow243]

The file https://github.com/cypht-org/cypht/blob/master/modules/recaptcha/recaptcha.ini should be removed as well.

Remove this please

[amaninyumu1]

I deleted this file https://github.com/cypht-org/cypht/blob/master/modules/recaptcha/recaptcha.ini

[Shadow243]

I just added the same condition at the recaptcha script level to prevent the js file from being reloaded: https://www.google.com/recaptcha/api.js when we don't need it.

You can test to see if there will be an error (in console and in logs)

[amaninyumu1]

yes it works