Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Improve Unicode Handling in DOMDocument HTML Loading #1133

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

kambereBr
Copy link
Member

This PR addresses an issue with Unicode character handling in the reply and reply-all functionalities.

@marclaporte marclaporte requested a review from Shadow243 July 25, 2024 20:22
Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see here Shadow243@51adb52 that it was htmlentities

modules/core/message_functions.php Outdated Show resolved Hide resolved
@kambereBr kambereBr force-pushed the unicode-domdocument-html branch from f5d2107 to 904727e Compare August 7, 2024 20:47
@kambereBr kambereBr requested a review from Shadow243 August 7, 2024 21:08
@Shadow243 Shadow243 merged commit 7ee1ef4 into cypht-org:master Aug 7, 2024
8 checks passed
@Shadow243
Copy link
Member

Shadow243 commented Aug 7, 2024

@Baraka24 you reported this, can you confirm if it's now fine ?

@Baraka24
Copy link
Member

Baraka24 commented Aug 7, 2024

@Shadow243 this fixes the issue as well. I have tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants