-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve JMAP compatibilities with stalwart #909
Conversation
…ccount' toplevel key so comment out checking isPrimary attr in account which doesnt exist
Currently, we have left it as draft pending this fix #902 which will fix email sending as it is not working for now. We have been not able to test send mail |
fwiw it seems 4bc4cea reverts the previous commits in hm-jmap |
We started with your commits then added another, we now have your 4 commits plus 1(5 commits) |
yes, but unless i'm mistaken and dont understand the github UI anymore, if you look at the actual PR contents on https://github.com/cypht-org/cypht/pull/909/files there's only a oneliner change which comes from 4bc4cea, and all the other changes from the previous 4 commits are reverted in it... so the complete PR doesn't actually contain 'my commits' |
@landryb is right - the original commits were reverted as part of another one - namely, this one: 4bc4cea @Shadow243 can you please revert that and start with the original 4 commits and then introduce the changes you want? I think we should address the commenting of the isPrimary check - if that's not needed, just remove the code. |
4bc4cea
to
441258b
Compare
…lib/repository.php:76 with php8.x
441258b
to
e9cecf9
Compare
Copy that. Changes separated here: e9cecf9 |
Thanks @Shadow243! @landryb do you plan to push more commits here or we can merge now? |
i havent been able to test more jmap since 1.5 year, so dont wait for me :) hopefully someday i'll be able to retest cypht against stalwart-jmap... |
This Pull Request follows a proposal that had been made: #648 adding support for JMAP in Cypht.