Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain how to modify list of browsers in the plugins file #2245

Merged
merged 32 commits into from
Nov 25, 2019

Conversation

bahmutov
Copy link
Contributor

related to new feature cypress-io/cypress#5068

jennifer-shehane and others added 13 commits October 24, 2019 13:34
Develop

Co-authored-by: Gleb Bahmutov <[email protected]>
Co-authored-by: Josef Biehler <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: Aman Bansal <[email protected]>
Develop

Co-authored-by: Aman Bansal <[email protected]>
Co-authored-by: Ian VanSchooten <[email protected]>
Develop

Co-authored-by: Gleb Bahmutov <[email protected]>
Co-authored-by: Oak Cooper <[email protected]>
Co-authored-by: Andrew Smith <[email protected]>
Co-authored-by: Shalini Sreedhar <[email protected]>
Co-authored-by: Zach Bloomquist <[email protected]>
Develop

Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marjy Guery <[email protected]>
Develop

Co-authored-by: Andrew Smith <[email protected]>
Co-authored-by: Florian Goussin <[email protected]>
Co-authored-by: Mariya Popova <[email protected]>
Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Martin Packman <[email protected]>
PRs are only created when other PRs into develop are merged.
Master

Co-authored-by: Gleb Bahmutov <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
Develop

Co-authored-by: Andrew Smith <[email protected]>
* add examples to code-coverage

* docs: fix typo

* docs: fix build errors
@jennifer-shehane jennifer-shehane changed the base branch from develop to 3.7.0-release November 14, 2019 20:47
@jennifer-shehane
Copy link
Member

This is a great writeup - I have some more places I want to mention this, but I moved this initial full guide into the 'Launching Browsers' guide, where we talk about the available browsers. I think this will be closer to the intent - if someone were looking to change what browsers are launched.

Gonna see if I can loop this in to other places in the docs, like the plugins - it's a bit awkward cause it doesn't use the plugin events. 🤔

@jennifer-shehane
Copy link
Member

Found it! I knew we have a specific guide showing how to manipulate the config in plugins. https://docs.cypress.io/api/plugins/configuration-api.html

@bahmutov
Copy link
Contributor Author

bahmutov commented Nov 14, 2019 via email

- reorder configuration api page so that it contains examples and is
better readable with multiple examples.
@jennifer-shehane
Copy link
Member

I want to update the image of the resolved configuration whenever the PR is definitely merged in 🙃 https://docs.cypress.io/guides/references/configuration.html#Resolved-Configuration

## Unsupported Browsers

Many browsers such as Firefox, Safari, and Internet Explorer are not currently supported. Support for more browsers is on our roadmap. You can read an exhaustive explanation about our future cross browser testing strategy {% issue 310 'here' %}.
Many browsers such as Firefox, Safari, and Internet Explorer are not currently supported. While it may be possible to modify the list of browsers found and run Cypress within them - we do not gaurantee full functionality. Support for more browsers is on our roadmap. You can read an exhaustive explanation about our future cross browser testing strategy {% issue 310 'here' %}.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gaurantee is an exotic fruit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a hard one, gonna add that to the linter 😅

@jennifer-shehane jennifer-shehane merged commit 4738751 into 3.7.0-release Nov 25, 2019
@matthamil matthamil deleted the custom-list-of-browsers branch April 14, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants