Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding chrome to the travis-ci example #822

Closed
wants to merge 1 commit into from

Conversation

paulfalgout
Copy link

By default travis comes with Chromium v61 which has some significant performance issues with Cypress v3. Users may also not expect that the tests are running in Chromium or understand that chrome is an option.

Introducing this would add extra opinion to the example that isn't necessarily needed, but I think not mentioning this in some fashion will lead to headaches that could be avoided.
https://docs.travis-ci.com/user/chrome#selecting-a-chrome-version

By default travis comes with Chromium v61 which has some [significant performance issues](cypress-io/cypress#1905 (comment)) with Cypress v3.  Users may also not expect that the tests are running in Chromium or understand that chrome is an option.

Introducing this would add extra opinion to the example that isn't necessarily needed, but I think not mentioning this in some fashion will lead to headaches that could be avoided.
https://docs.travis-ci.com/user/chrome#selecting-a-chrome-version
@CLAassistant
Copy link

CLAassistant commented Aug 8, 2018

CLA assistant check
All committers have signed the CLA.

@paulfalgout paulfalgout changed the title Consider adding chrome to the example Consider adding chrome to the travis-ci example Aug 8, 2018
@jennifer-shehane jennifer-shehane requested a review from kuceb August 8, 2018 16:27
@kuceb
Copy link
Contributor

kuceb commented Aug 8, 2018

Since all the other example CI configs do not have chrome installed, it might confuse users why only one example involves installing chrome. Likely we should include CI configs using the docker images here https://github.com/cypress-io/cypress-docker-images/tree/master/browsers

@paulfalgout
Copy link
Author

To my knowledge travis comes with only chromium and not chrome where as circleci has chrome by default I believe, so it isn't necessary to specify. But are you suggesting that if you're using CI, docker would be the only documented solution?

@kuceb
Copy link
Contributor

kuceb commented Aug 8, 2018

Correct. For using Chrome, the only documented solution is using a Docker image or having Chrome preinstalled somehow- like on the a Jenkins machine

@kuceb
Copy link
Contributor

kuceb commented Aug 8, 2018

This will be further the case when we release Firefox support...Docker images with both browsers pre-installed is the simplest solution.

@paulfalgout
Copy link
Author

Hmm perhaps on a new project. If you already have a significantly complicated travis run, docker does not necessarily simplify things. Where-as if I want to run firefox in travis with my current config it is a single line in the yml

The issue as I see it is there was/is issues with electron running on CI and in other issues the solution offered was to try chrome, but with -- browser chrome for anyone running travis by default that gives you chromium and it has similar problems to electron, and unless you are really paying attention it is hard to notice that it falls back to chromium.

@kuceb
Copy link
Contributor

kuceb commented Nov 2, 2018

@paulfalgout so you can get both chrome and firefox on travis using only travis.yml, without needing a docker image? In that case, perhaps this is easier for users on travis

@jennifer-shehane
Copy link
Member

@bkucera Any conclusion to this PR? I will be closing very soon if no response.

@jennifer-shehane
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants