-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding chrome to the travis-ci example #822
Conversation
By default travis comes with Chromium v61 which has some [significant performance issues](cypress-io/cypress#1905 (comment)) with Cypress v3. Users may also not expect that the tests are running in Chromium or understand that chrome is an option. Introducing this would add extra opinion to the example that isn't necessarily needed, but I think not mentioning this in some fashion will lead to headaches that could be avoided. https://docs.travis-ci.com/user/chrome#selecting-a-chrome-version
Since all the other example CI configs do not have chrome installed, it might confuse users why only one example involves installing chrome. Likely we should include CI configs using the docker images here https://github.com/cypress-io/cypress-docker-images/tree/master/browsers |
To my knowledge travis comes with only chromium and not chrome where as circleci has chrome by default I believe, so it isn't necessary to specify. But are you suggesting that if you're using CI, docker would be the only documented solution? |
Correct. For using Chrome, the only documented solution is using a Docker image or having Chrome preinstalled somehow- like on the a Jenkins machine |
This will be further the case when we release Firefox support...Docker images with both browsers pre-installed is the simplest solution. |
Hmm perhaps on a new project. If you already have a significantly complicated travis run, docker does not necessarily simplify things. Where-as if I want to run firefox in travis with my current config it is a single line in the yml The issue as I see it is there was/is issues with electron running on CI and in other issues the solution offered was to try chrome, but with |
@paulfalgout so you can get both chrome and firefox on travis using only travis.yml, without needing a docker image? In that case, perhaps this is easier for users on travis |
@bkucera Any conclusion to this PR? I will be closing very soon if no response. |
Closing due to inactivity. |
By default travis comes with Chromium v61 which has some significant performance issues with Cypress v3. Users may also not expect that the tests are running in Chromium or understand that chrome is an option.
Introducing this would add extra opinion to the example that isn't necessarily needed, but I think not mentioning this in some fashion will lead to headaches that could be avoided.
https://docs.travis-ci.com/user/chrome#selecting-a-chrome-version