Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

chore: skip svelte unit tests for now #97

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jul 6, 2020

issue due to rollup update: https://circleci.com/gh/cypress-io/cypress-test-example-repos/110563

blocking 4.10.0 release, skipping for now

issue due to rollup update: https://circleci.com/gh/cypress-io/cypress-test-example-repos/110563

blocking 4.10.0 release, skipping for now
@flotwig flotwig requested a review from bahmutov July 6, 2020 20:10
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, skip it

@flotwig
Copy link
Contributor Author

flotwig commented Jul 6, 2020

@bahmutov what to do about the failing recipes? doesn't seem to be flake, should we skip them as well?

@bahmutov
Copy link
Contributor

bahmutov commented Jul 7, 2020

yeah, I think we can skip for now, but need to record the failure as an issue to remember to investigate

@flotwig
Copy link
Contributor Author

flotwig commented Jul 7, 2020

afaict, the issue started happening with cypress-io/cypress-example-kitchensink#412, but i could be mixing up the cause

updated this PR to skip these tests and created an issue: #98

@flotwig flotwig requested a review from bahmutov July 7, 2020 14:27
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping for now

@flotwig flotwig merged commit 2985dae into master Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants