chore: ignore node_modules for webpack dev server

cypress-io · Aug 21, 2024 · 77b5dee · 77b5dee
1 parent 31b8610
commit 77b5dee
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/npm/webpack-dev-server/src/makeDefaultWebpackConfig.ts b/npm/webpack-dev-server/src/makeDefaultWebpackConfig.ts
@@ -99,11 +99,13 @@ export function makeCypressWebpackConfig (
     devtool: 'inline-source-map',
   } as any
 
-  // if experimentalJustInTimeCompile is configured, we need to watch for file changes as the spec entries are going to be updated per test
-  if (isRunMode && !experimentalJustInTimeCompile) {
+  if (isRunMode) {
+    // if experimentalJustInTimeCompile is configured, we need to watch for file changes as the spec entries are going to be updated per test
+    const ignored = experimentalJustInTimeCompile ? /node_modules/ : '**/*'
+
     // Disable file watching when executing tests in `run` mode
     finalConfig.watchOptions = {
-      ignored: '**/*',
+      ignored,
     }
   }
 

diff --git a/npm/webpack-dev-server/test/makeWebpackConfig.spec.ts b/npm/webpack-dev-server/test/makeWebpackConfig.spec.ts
@@ -495,7 +495,7 @@ describe('makeWebpackConfig', () => {
               }),
             })
 
-            expect(actual.watchOptions?.ignored).to.be.undefined
+            expect(actual.watchOptions?.ignored).to.deep.equal(/node_modules/)
           })
         })
       })
-Original file line number
+Diff line change
@@ Expand Up / @@ -495,7 +495,7 @@ describe('makeWebpackConfig', () => { @@
                   }),
                 })
-                expect(actual.watchOptions?.ignored).to.be.undefined
+                expect(actual.watchOptions?.ignored).to.deep.equal(/node_modules/)
               })
             })
           })
@@ Expand Down @@