feat: component testing #14479

brian-mann · 2021-01-11T07:25:16Z

No description provided.

- TODO: need to fix our custom circular parser to work with socket.io engine 3.x.x

…ocket-ct - move all reusable logic into socket-base, only split out what is different in each socket class

…ach test

* types: fix types * types: use target es6 * types: use Promise for async/await * types: lint

- add middleware interfaces

- provide good error reason as to why the property isn’t yet available - use TS generics for proper type autocompletion

… socket v3

….requests

fix(component-testing): start dev server event typings

kuceb

cant comment on the files individually
npm/vue/examples/cli-ts/cypress/plugins/index.ts is a .ts file but uses requires, any reason?
looks like this PR adds back in no-only eslint plugin, which we removed previously. possibly a mis-merge? I can push a commit to fix.

kuceb · 2021-02-03T16:02:23Z

enabled running example repos and testing binary build for this branch

flotwig

This looks fine for initial beta release - my comments are all things that can be fixed in future PRs.

My only major concerns are:

code duplication - in the server-ct, and especially in the runner-ct, lots of code is duplicated. it would be a shame if these unnecessarily diverged and introduced inconsistent user experience, so i feel that a refactor of both these areas is in immediate need
this is not specific to CT, but the type exports (cli/types/...) are a messssss and are only getting worse :/

Super happy about all the typescriptification in this PR too, and excited for CT to drop!

flotwig · 2021-02-02T20:42:49Z

packages/server/lib/server-e2e.ts

+    this._urlResolver = null
+  }
+
+  open (config = {}, project, onError, onWarning) {


This can be deduplicated with server-ct#open, it is vastly the same

.eslintrc.json

flotwig · 2021-02-03T17:48:28Z

.vscode/tasks.json

+  // See https://go.microsoft.com/fwlink/?LinkId=733558
+  // for the documentation about the tasks.json format


interesting, i wonder if we should convert our terminals.json to this format

no idea - I don't use these at all, I guess someone else aded them. Might check it out and so I can start using vscode more effectively...

flotwig · 2021-02-03T17:49:06Z

.vscode/terminals.json

+    {
+      "name": "packages/server test-e2e",
+      "focus": true,
+      "onlySingle": true,
+      "execute": false,
+      "cwd": "[cwd]/packages/server",
+      "command": "yarn test-e2e [fileBasename]"
+    },


should work the same as packages/server test, so doesn't really need to be added

flotwig · 2021-02-03T17:51:17Z

circle.yml

+  server-ct-unit-tests:
+    <<: *defaults
+    parallelism: 1
+    steps:
+      - attach_workspace:
+          at: ~/
+      - check-conditional-ci
+      - run: yarn test-unit --scope @packages/server-ct
+      - verify-mocha-results:
+          expectedResultCount: 1
+      - store_test_results:
+          path: /tmp/cypress
+      - store-npm-logs
+


so, unfortunately, we are over github's 100 checks/commit limit in develop...... this makes it urgent to find a way to cut down, as with every new job we add, the chance of another check randomly failing and going unreported increases

I see. Oof. We're gonna need to get on the phone and figure out how to do that.

flotwig · 2021-02-03T18:49:15Z

packages/server/lib/browsers/chrome.ts

+
+    return


Suggested change

return

lolwut

flotwig · 2021-02-03T18:51:24Z

packages/server/lib/browsers/utils.ts

@@ -236,6 +236,12 @@ export = {

      debug('found browsers %o', { browsers })

+      if (!process.versions.electron) {
+        debug('not in electron, skipping adding electron browser')


so happy to see us start doing node-only testing, users have been asking for this

flotwig · 2021-02-03T18:57:08Z

packages/server/lib/modes/index.js

-      return require('./smoke_test').run(options)
-    default:
-      break
+  if (mode === 'record') {


aw i liked the switch statement

flotwig · 2021-02-03T18:57:47Z

packages/server/lib/open_project.js

-          options.url = url
-
-          options.isTextTerminal = cfg.isTextTerminal
+          _.defaults(options, {


good place to use pick

flotwig · 2021-02-03T19:01:28Z

packages/server/lib/plugins/index.js

+    if (inspector.url()) {
+      childOptions.execArgv = _.chain(process.execArgv.slice(0))
+      .remove('--inspect-brk')
+      .push(`--inspect=${process.debugPort + 1}`)


i guess this kinda addresses #5802 ?

…ting

This reverts commit cbcf0d4.

…ting

brian-mann and others added 30 commits January 5, 2021 02:27

convert packages socket -> ts, upgrade socket.io to 3.x.x

4240232

- TODO: need to fix our custom circular parser to work with socket.io engine 3.x.x

replace browserify with webpack in packages/extension

39cd18a

finished consolidating and refactoring socket-base, socket-e2e, and s…

342b05c

…ocket-ct - move all reusable logic into socket-base, only split out what is different in each socket class

use automation api's to reset server state and browser state before e…

3ff21b9

…ach test

remove custom parser

b73871d

remove additional circularParser ref

3ba598b

types: fix types (#14401)

116fdf2

* types: fix types * types: use target es6 * types: use Promise for async/await * types: lint

fix: add xhrs

f4f07df

wip: work on linting

a58228a

chore: linting

50fce54

convert lib/automation into typescript

93a8085

- add middleware interfaces

convert automation/screenshot into typescript

ca0a7d1

convert automation/cookies into typescript

97c3dbf

let -> const

70d7dd2

create ensureProp class helper to validate that properties are available

ef7dc68

- provide good error reason as to why the property isn’t yet available - use TS generics for proper type autocompletion

move around specific e2e method

2192d3f

fix a bunch of types, improve type completion

0be806f

consolidate createRoutes

5e26100

add ts-no-check again

7e6d19f

dont check this file either

57208ef

types: remove return type

16ed422

fix failing tests, listen to 'error' not 'connect_error' event due to…

86b4503

… socket v3

dont use it.only

2113d9e

fix: correctly use new for automation class

277088a

properly bind the automation#response method so it has access to this…

b9951ae

….requests

fix: add missing get function

7e03f2b

fix: use this to get correct ctx

94d561c

fix: use new screenshot class correctly

23e61d1

reset the maxHttpBufferSize in socket.io server to be the previous v2

b9f432e

tests: fix some tests

54c9e14

elevatebart and others added 7 commits February 1, 2021 16:22

fix start server event typings

4194523

align typings

096afaa

remove extraneous column

f20ab91

Use the types in vue/react examples

79ec906

type http server

5b94d57

update dependencies on node types

c1644b0

Merge pull request #14855 from cypress-io/feat/evergreen-typings

6dfaa23

fix(component-testing): start dev server event typings

kuceb suggested changes Feb 3, 2021

View reviewed changes

kuceb added 2 commits February 3, 2021 11:01

remove eslint plugin no-only-tests

3ccbb91

add binary build to branch

b76b8d6

use webpack for packages/extension build, small fixes

cbcf0d4

flotwig previously approved these changes Feb 3, 2021

View reviewed changes

kuceb previously approved these changes Feb 3, 2021

View reviewed changes

JessicaSachs dismissed stale reviews from kuceb and flotwig via ad08b6d February 3, 2021 23:02

Merge remote-tracking branch 'origin/develop' into feat/component-tes…

b67831b

…ting

JessicaSachs force-pushed the feat/component-testing branch from ad08b6d to b67831b Compare February 3, 2021 23:35

lmiller1990 and others added 6 commits February 4, 2021 11:56

chore: update yarn.lock

d84e4e3

Revert "use webpack for packages/extension build, small fixes"

6d4cfdf

This reverts commit cbcf0d4.

updating package-lock

eabd354

Merge branch 'develop' into feat/component-testing

8e9261e

Merge remote-tracking branch 'origin/develop' into feat/component-tes…

8250779

…ting

syntax error

5ef3d13

JessicaSachs approved these changes Feb 4, 2021

View reviewed changes

JessicaSachs merged commit af26fbe into develop Feb 4, 2021

JessicaSachs deleted the feat/component-testing branch February 4, 2021 20:45

jennifer-shehane mentioned this pull request Mar 16, 2021

Reloading Cypress after unexpected error results in crash #15360

Closed

This was referenced Apr 28, 2021

RangeError: Maximum call stack size exceeded at _deconstructPacket in CI Pipeline #15101

Closed

fix: Correctly handle if cb is undefined in wrapChildPromise #16277

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: component testing #14479

feat: component testing #14479

brian-mann commented Jan 11, 2021

kuceb left a comment

kuceb commented Feb 3, 2021

flotwig left a comment

flotwig Feb 2, 2021

flotwig Feb 3, 2021

lmiller1990 Feb 3, 2021

flotwig Feb 3, 2021

flotwig Feb 3, 2021

JessicaSachs Feb 3, 2021

flotwig Feb 3, 2021

flotwig Feb 3, 2021

flotwig Feb 3, 2021

flotwig Feb 3, 2021

flotwig Feb 3, 2021

		// See https://go.microsoft.com/fwlink/?LinkId=733558
		// for the documentation about the tasks.json format

feat: component testing #14479

feat: component testing #14479

Conversation

brian-mann commented Jan 11, 2021

kuceb left a comment

Choose a reason for hiding this comment

kuceb commented Feb 3, 2021

flotwig left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment