Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: component testing #14479
feat: component testing #14479
Changes from all commits
4240232
39cd18a
342b05c
3ff21b9
b73871d
3ba598b
116fdf2
f4f07df
a58228a
50fce54
93a8085
ca0a7d1
97c3dbf
70d7dd2
ef7dc68
2192d3f
0be806f
5e26100
7e6d19f
57208ef
16ed422
86b4503
2113d9e
277088a
b9951ae
7e03f2b
94d561c
23e61d1
b9f432e
54c9e14
9b103b9
c8a287b
81971a4
fae3624
aa03dd1
1fe4149
65dce64
3f06c62
55b63e0
ec0277b
f2de406
e1972a3
bc2adc8
2a751b6
57dbd98
8922969
f974e69
31a6148
7a21e50
f7420d1
364a59a
0ce67d3
5925215
6158393
e30dd07
5a49c1f
f4a9852
4090c50
d0d8935
866d25d
58433a7
43029e3
63b9f59
c76ce37
dd3f870
16c1e0f
3dba316
df4ad93
2c40ebc
446a6d7
8dd988d
496fdd6
f6271f4
b8a6de1
f29d2d9
90bd098
046f2b6
4274d3b
384fc73
4d6c985
e221420
d5b191e
0652d7e
67f423b
97c7eb4
78f6276
1a9ef9e
650bc34
13356c2
d953c06
a8b6c14
3b57282
82bca03
ea18aee
369d453
5397cfc
cf71c31
0f646ab
eecf1f0
a8f5206
e00f081
c8ceaa1
9cba5ca
1bfb613
c3237f7
cf5fd53
ee8fbd2
a2a001d
3ea6d7c
6467faf
6df66a5
8152b3c
5d385de
0a10cdf
2d30ada
8803e6a
692f218
f3fa6ca
00a5e8a
1d4cbcb
4fceac8
2d17b55
29ba8ba
ffe6391
cec8949
4f7d09e
16e2a8e
3aac39a
fb8e71c
15a591f
17b8f13
053ff82
4830084
f5acf6c
557e219
b33bd27
aa6c191
a3c270c
739a9e1
8e5a5db
b5a2361
4b56847
844ed86
e18e9b5
e3fcb5d
865a7ae
af0efce
ff6cb54
1a9bd83
9292b9e
3cb2d05
3bb72f8
77cd12e
869d727
ec87901
1b1d390
a60de7f
f5b613e
18f827a
bc467c0
7556e80
0e3d7fb
86809cb
9526eaf
06cebd8
6c09d22
fd1af0c
49a5725
e4a9746
6c02435
e7e859a
8ece880
90b7cf8
8fb3b6c
91235b3
0a9ea0c
53788be
1fe1cfe
c27778e
ab55e83
157fb5e
be19591
cad9ffe
843acde
bdcb781
d6e185a
79afc81
589b18c
e8c34b8
8e9d68e
3cbe96a
50be1b5
24e8036
9f4ce51
b5509a7
2e809a2
da6c14d
1da7661
64d4150
655470f
454983c
13ffdb0
28ec7f9
e598532
def25e4
d2c78b1
5eaeb33
e89da7a
be688e7
6d3f975
d4a888d
c99a703
286b033
c39d84b
13941fc
cb9127e
3eb6f14
60158a2
5595fed
23b8a6b
b5f021d
af0a9fd
e8e8562
0842a42
d51f897
cdc76d3
c4b4e23
7cad4b0
8d3c985
81b9ad3
acb8b38
b0f324b
df2586d
4194523
096afaa
f20ab91
79ec906
5b94d57
c1644b0
6dfaa23
3ccbb91
b76b8d6
cbcf0d4
b67831b
d84e4e3
6d4cfdf
eabd354
8e9261e
8250779
5ef3d13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, i wonder if we should convert our terminals.json to this format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea - I don't use these at all, I guess someone else aded them. Might check it out and so I can start using vscode more effectively...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should work the same as
packages/server test
, so doesn't really need to be addedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, unfortunately, we are over github's 100 checks/commit limit in
develop
...... this makes it urgent to find a way to cut down, as with every new job we add, the chance of another check randomly failing and going unreported increasesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Oof. We're gonna need to get on the phone and figure out how to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto, would be nice to run this without adding a new job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to go before release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a run-ct command yet so this can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep this is coming: #14902
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems it is useful for debugging (see line 23 in this file. it is exported). it is only referenced in one file,
xvfb_spec.js
. I am guessing it was added to debug a specific issue. Do you think we should remove it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used here: https://github.com/cypress-io/cypress/pull/14479/files#diff-461ea613480dd2c64bbd8617d18cf2ee72449c9d6d3680b6e5bd43d049eab0e4R25