feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead #18422

BlueWinds · 2021-10-08T19:00:23Z

Closes Add deprecation warnings for component testing commands #18418

User facing changelog

cypress run-ct and cypress open-ct are deprecated and will be removed in a future version. Use Use cypress [open|run] --ct or cypress [open|run] --component instead.

PR Tasks

Have tests been added/updated?
Has the original issue or this PR been tagged with a release in ZenHub?

cypress-bot · 2021-10-08T19:00:25Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

packages/server/lib/modes/interactive-e2e.js

chrisbreiding

I tested this out manually and verified it works as intended.

Other than the log formatting changes, this needs a test of some kind, at least testing the DataContext change.

There are also a lot of failing tests that aren't failing in the base branch. Need to fix those before this can be merged in.

cli/lib/cli.js

emilyrohrbough · 2021-10-12T14:01:30Z

packages/data-context/src/DataContext.ts

@@ -61,6 +61,13 @@ export class DataContext extends DataContextShell {
      toAwait.push(this.actions.project.setActiveProject(this.config.launchArgs.projectRoot))
    }

+    if (this.config.launchArgs.testingType) {


Is it possible to test this?

Soon. Working on the testing infrastructure for open mode right now

@tgriesser Do you think there's any value in unit tests for this?

I went ahead and wrote one. Happy to change the approach there if people have opinions.

cli/__snapshots__/cli_spec.js

…e2e or --ct are used (if LAUNCHPAD=1)

cli/lib/cli.js

…18418-deprecate-open-ct

packages/server/lib/util/args.js

…18418-deprecate-open-ct

…ate-open-ct

…18418-deprecate-open-ct

emilyrohrbough · 2021-10-15T17:28:59Z

packages/server/lib/modes/index.ts

-    return require('./run-ct').run(options)
-  }
+  if (mode === 'interactive') {
+    if (options.testingType === 'component' && !process.env.LAUNCHPAD) {


Is there documentation around the LAUNCHPAD env? I'm probably missing it but haven't found it yet

Not that I've found either. Speaking with the CT team, the original plan was to merge launchpad into the develop behind this flag, but plans changed, and now the env variable will be removed before launch.

I'm not removing it here in this PR though, because that's a change which will, I expect, have massive ramifications for our tests on cypress - at the very least every system test that assumes cypress open drops it into the e2e testing mode will need an update.

…18418-deprecate-open-ct

cypress · 2021-10-22T17:34:53Z

Test summary

4206 • 0 • 50 • 2 • 1

Run details


Project	cypress
Status	Passed
Commit	`50555f5`
Started	Oct 25, 2021 8:45 PM
Ended	Oct 25, 2021 8:56 PM
Duration	11:11 💡
OS	Linux Debian - 10.9
Browser	Electron 93

View run in Cypress Dashboard ➡️

Flakiness

	cypress/integration/e2e/redirects_spec.js		1
1	redirection > meta > binds to the new page after a timeout

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

packages/driver/cypress/integration/commands/assertions_spec.js

packages/driver/cypress/integration/commands/navigation_spec.js

packages/driver/cypress/integration/commands/request_spec.js

packages/data-context/test/unit/data-context.spec.ts

Co-authored-by: Chris Breiding <[email protected]>

* unified-desktop-gui: feat: Adding a cache layer for remote queries, e2e test helpers (#18652) fix: overflow clip to prevent selector header from dissapearing (#18649) feat(unify): command log color update (#18596) build: run frontend-shared tests in CI (#18628) Update README.md feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead (#18422) feat(unify): add growth prompts (#18626)

BlueWinds requested a review from a team as a code owner October 8, 2021 19:00

BlueWinds requested review from chrisbreiding and jennifer-shehane and removed request for a team October 8, 2021 19:00

BlueWinds changed the title ~~Deprecate run-ct / open-ct, and update all examples to use --ct instead~~ feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead Oct 8, 2021

BlueWinds changed the title ~~feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead~~ chore: Deprecate run-ct / open-ct, and update all examples to use --ct instead Oct 8, 2021

BlueWinds changed the title ~~chore: Deprecate run-ct / open-ct, and update all examples to use --ct instead~~ feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead Oct 8, 2021

BlueWinds force-pushed the issue-18418-deprecate-open-ct branch from 19c40e0 to 4dec064 Compare October 8, 2021 22:06

chrisbreiding requested changes Oct 11, 2021

View reviewed changes

packages/server/lib/modes/interactive-e2e.js Outdated Show resolved Hide resolved

BlueWinds force-pushed the issue-18418-deprecate-open-ct branch from 4dec064 to c89d6cf Compare October 11, 2021 18:35

BlueWinds requested review from tgriesser and chrisbreiding October 11, 2021 19:48

chrisbreiding requested changes Oct 12, 2021

View reviewed changes

cli/lib/cli.js Outdated Show resolved Hide resolved

cli/lib/cli.js Outdated Show resolved Hide resolved

emilyrohrbough reviewed Oct 12, 2021

View reviewed changes

cli/lib/cli.js Outdated Show resolved Hide resolved

emilyrohrbough reviewed Oct 12, 2021

View reviewed changes

cli/__snapshots__/cli_spec.js Outdated Show resolved Hide resolved

cowboy requested a review from a team October 12, 2021 15:04

BlueWinds added 5 commits October 12, 2021 09:54

Deprecate run-ct / open-ct, and update all examples to use --ct instead

ecbd8b8

Main cypress open script now always goes through launchpad even if --…

d1fa34e

…e2e or --ct are used (if LAUNCHPAD=1)

Skip testing type step when --e2e or --component passed in

72196f1

Fix unit tests, typescript error

ce398fc

Standardize on --component, misc review feedback

5367165

BlueWinds force-pushed the issue-18418-deprecate-open-ct branch from fea1a39 to 5367165 Compare October 12, 2021 16:56

chrisbreiding requested changes Oct 12, 2021

View reviewed changes

cli/lib/cli.js Outdated Show resolved Hide resolved

cli/lib/cli.js Outdated Show resolved Hide resolved

chrisbreiding self-assigned this Oct 12, 2021

BlueWinds added 2 commits October 13, 2021 08:28

Merge remote-tracking branch 'origin/unified-desktop-gui' into issue-…

1022281

…18418-deprecate-open-ct

Fix remaining review comments

c815aed

chrisbreiding reviewed Oct 14, 2021

View reviewed changes

packages/server/lib/util/args.js Show resolved Hide resolved

Merge remote-tracking branch 'origin/unified-desktop-gui' into issue-…

63b8385

…18418-deprecate-open-ct

BlueWinds added 2 commits October 14, 2021 10:49

Merge remote-tracking branch 'origin/develop' into issue-18418-deprec…

aae8059

…ate-open-ct

Merge remote-tracking branch 'origin/unified-desktop-gui' into issue-…

f4ab60d

…18418-deprecate-open-ct

emilyrohrbough reviewed Oct 15, 2021

View reviewed changes

BlueWinds added 5 commits October 21, 2021 09:35

Merge branch 'unified-desktop-gui' into issue-18418-deprecate-open-ct

07b9e48

Merge remote-tracking branch 'origin/unified-desktop-gui' into issue-…

835cb4f

…18418-deprecate-open-ct

Typo in merge resolution

3b0a727

Attempt to fix test failures

9fbdac9

Fix more test failures

5fa70ca

BlueWinds added 6 commits October 22, 2021 10:40

Remove circular dependency

44f8727

Add retries to driver request spec

fe66cb9

Improvements on removed circular dependency

581bb19

Undo broken change

19674b3

Add retries to flaky integration tests (unrelated to PR)

155fb32

Add basic DataContext unit test

6601c42

BlueWinds requested a review from chrisbreiding October 22, 2021 20:16

chrisbreiding requested changes Oct 25, 2021

View reviewed changes

Apply suggestions from code review

50555f5

Co-authored-by: Chris Breiding <[email protected]>

BlueWinds requested review from chrisbreiding, emilyrohrbough and cowboy October 25, 2021 20:48

chrisbreiding approved these changes Oct 25, 2021

View reviewed changes

chrisbreiding merged commit 196e8f6 into unified-desktop-gui Oct 26, 2021

cypress-bot bot mentioned this pull request Oct 26, 2021

Add deprecation warnings for component testing commands #18418

Closed

BlueWinds mentioned this pull request Oct 27, 2021

test(unify): Add system tests for --e2e and --component options #18653

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead #18422

feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead #18422

BlueWinds commented Oct 8, 2021

cypress-bot bot commented Oct 8, 2021

chrisbreiding left a comment

emilyrohrbough Oct 12, 2021 •

edited

Loading

tgriesser Oct 12, 2021

chrisbreiding Oct 12, 2021

BlueWinds Oct 22, 2021

emilyrohrbough Oct 15, 2021

BlueWinds Oct 15, 2021

cypress bot commented Oct 22, 2021 •

edited

Loading

feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead #18422

feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead #18422

Conversation

BlueWinds commented Oct 8, 2021

User facing changelog

PR Tasks

cypress-bot bot commented Oct 8, 2021

chrisbreiding left a comment

Choose a reason for hiding this comment

emilyrohrbough Oct 12, 2021 • edited Loading

Choose a reason for hiding this comment

tgriesser Oct 12, 2021

Choose a reason for hiding this comment

chrisbreiding Oct 12, 2021

Choose a reason for hiding this comment

BlueWinds Oct 22, 2021

Choose a reason for hiding this comment

emilyrohrbough Oct 15, 2021

Choose a reason for hiding this comment

BlueWinds Oct 15, 2021

Choose a reason for hiding this comment

cypress bot commented Oct 22, 2021 • edited Loading

Test summary

Run details

Flakiness

emilyrohrbough Oct 12, 2021 •

edited

Loading

cypress bot commented Oct 22, 2021 •

edited

Loading