Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unify): add growth prompts #18626

Merged
merged 61 commits into from
Oct 25, 2021
Merged

feat(unify): add growth prompts #18626

merged 61 commits into from
Oct 25, 2021

Conversation

marktnoonan
Copy link
Contributor

Additional details

This PR:

  • adds some icons and logos
  • extends our Button component to render an <a> instead of a <button> if a href prop is passed. This is pretty much the API that Veutify provides as well. The setup for this is kind of verbose but means the one set of styles we have created to represent the buttons from Figma can be used regardless of whether the right element is a link or true button.
  • pulls the docs menu content into its own component as TopNav was getting a bit crowed with the new sections
  • adds the growth prompts. For keyboard a11y reasons they are actually a state of the docs menu itself, as the docs menu focus/open state needs to be maintained. There's also a little bit of a workaround here to reset the prompt when menu closes. I'd really like if Headless UI emitted a 'change' event when the state of the component changed so we didn't need the workaround.
  • reworks TopNav to make room for the new prompts

How has the user experience changed?

growth.prompts.mov

How to test

Open the launchpad, and in the docs menu click on "Setup CI" or "Smart Orchestration and the related prompt should appear.

PR Tasks

  • Have tests been added/updated?

@marktnoonan
wip Install Dependencies styles
ba09ea5
@marktnoonan
add clipboard icon
4e68fc7
@marktnoonan
add tertiary Button variant from figma
463b81f
@marktnoonan
position button
3901440
@marktnoonan
change copy button to script setup, use button for status message
4d7598b
@marktnoonan
additional styling
3881d2c
@marktnoonan
wrap up install dependencies style
84425e8
@marktnoonan
restore cypress.json
6d6525f
@marktnoonan
update test for new expectations
3386440
@marktnoonan
move TranisitionQuickFade to frontend shared
f7e05e8
@marktnoonan
fix width measurement
9ae6eb1
@marktnoonan
Merge branch 'unified-desktop-gui' into UNIFY-355-install-dependencie…
9b73f7b 
…s-page
@marktnoonan
remove example generated plugins file
dbaf910
@marktnoonan
Merge branch 'unified-desktop-gui' into UNIFY-355-install-dependencie…
e905bd5 
…s-page
@marktnoonan
Add Fira Mono font and use for monospace font-family
fc01b0c
@marktnoonan
use useClipboard for copy button
bd33d99
@marktnoonan
fix testing type button
f0a924f
@marktnoonan
dial in font for monospace
e0644e5
@marktnoonan
Merge branch 'unified-desktop-gui' into UNIFY-355-install-dependencie…
29a1c10 
…s-page
@marktnoonan
style tweak
5bf4e2a
@marktnoonan
remove unused tabindex attr
f038787
@marktnoonan
switch to Fira Code instead of Fira Mono
cb92ec0
@marktnoonan
remove unusued component
2fcaa7f
@marktnoonan
tweak some sizes around copy button
843f07d
@marktnoonan
remove PackagesList fragment
8267d1a
@marktnoonan
some setup to get prompt info exposed in gql
fd6f2bb
@marktnoonan
some mock data for prompts
7ee3c69
@marktnoonan
remove prompts wip
c196170
@marktnoonan
Merge branch 'unified-desktop-gui' into UNIFY-355-install-dependencie…
8c8b173 
…s-page
@marktnoonan
line break
ef62e59
@marktnoonan
get basic orchestration content rendering
2dab6a5
@marktnoonan
split up display in of growth popups
3291a27
@marktnoonan
add logic to avoid rendering empty slot wrapper
14b88da
@marktnoonan
add lightning icon
d591d52
@marktnoonan
UI cleanup & i18n
02abe25
@marktnoonan
add target to link-button
9dd990b
@marktnoonan
basic component test
9fad2a8
@marktnoonan
convert ci buttons to use Button
bf237ee
@marktnoonan
reset prompts as needed
092b82a
@marktnoonan
Merge branch 'unified-desktop-gui' into UNIFY-406-growth-modal
c6897fb
@marktnoonan
split out url helper
926beff
@marktnoonan
split out docs menu content from topnav
89fe039
@marktnoonan
split out docs menu content from topnav
2ca33b2
@marktnoonan
use url helper to add params
c12f3b9
@marktnoonan
only show growth prompts when a project has been chosen
a7f1aec
@marktnoonan
cleanup
327744f
@marktnoonan
update test
3d23aea
@marktnoonan
fix .ts imports
b2f7575
@marktnoonan
finish up params in growth prompts
2225e1d
@marktnoonan
add animation
73a34b3
@marktnoonan
docs menu link styles
66aa495
@marktnoonan
add aria live region
a86e69b
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Oct 25, 2021


Test summary

18554 • 3 • 216 • 7 • Flakiness 3

Run details
Project cypress
Status Failed
Commit a86e69b
Started Oct 25, 2021 7:27 PM
Ended Oct 25, 2021 7:44 PM
Duration 17:12 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

navigation_spec.js 1 Failed
1 ... > throws when headers is not an object
assertions_spec.js 1 Failed
1 ... > rejects any element not in the document
window_spec.js 1 Failed
1 ... > throws when passed the invalid: '[object Object]' as width

Flakiness

commands/net_stubbing_spec.ts 1 Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
e2e/redirects_spec.js 1 Flakiness
1 redirection > meta > binds to the new page after a timeout
cypress/proxy-logging-spec.ts 1 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

JessicaSachs
JessicaSachs approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed some imports and swapped animation to be driven by TW.

@marktnoonan marktnoonan merged commit 0d098ae into unified-desktop-gui Oct 25, 2021
@marktnoonan marktnoonan deleted the UNIFY-406-growth-modal branch October 25, 2021 20:51
tgriesser added a commit that referenced this pull request Oct 27, 2021
@tgriesser
Merge branch 'unified-desktop-gui' into tgriesser/refactor/move-runs
d8948af 
* unified-desktop-gui:
  feat: Adding a cache layer for remote queries, e2e test helpers (#18652)
  fix: overflow clip to prevent selector header from dissapearing (#18649)
  feat(unify): command log color update (#18596)
  build: run frontend-shared tests in CI (#18628)
  Update README.md
  feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead (#18422)
  feat(unify): add growth prompts (#18626)
tgriesser added a commit that referenced this pull request Oct 27, 2021
@tgriesser
Merge branch 'unified-desktop-gui' into refactor/move-runs
57e3eca 
* unified-desktop-gui:
  feat: Adding a cache layer for remote queries, e2e test helpers (#18652)
  fix: overflow clip to prevent selector header from dissapearing (#18649)
  feat(unify): command log color update (#18596)
  build: run frontend-shared tests in CI (#18628)
  Update README.md
  feat: Deprecate run-ct / open-ct, and update all examples to use --ct instead (#18422)
  feat(unify): add growth prompts (#18626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaSachs JessicaSachs JessicaSachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marktnoonan @JessicaSachs