Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new fontawesome spinner icon is visually clipped in 3.8.0 prerelease #5863

Closed
kuceb opened this issue Dec 3, 2019 · 2 comments · Fixed by #5870
Closed

new fontawesome spinner icon is visually clipped in 3.8.0 prerelease #5863

kuceb opened this issue Dec 3, 2019 · 2 comments · Fixed by #5870
Labels
type: regression A bug that didn't appear until a specific Cy version release type: user experience Improvements needed for UX

Comments

@kuceb
Copy link
Contributor

kuceb commented Dec 3, 2019 •
edited
Loading

new fontawesome spinner icon is visually clipped

19-12-03_13:55::50

introduced in: #5822
@kuceb kuceb added the type: user experience Improvements needed for UX label Dec 3, 2019
@kuceb kuceb changed the title new fontawesome spinner icon is clipped new fontawesome spinner icon is visually clipped Dec 3, 2019
@kuceb kuceb added the type: regression A bug that didn't appear until a specific Cy version release label Dec 3, 2019
@kuceb kuceb mentioned this issue Dec 3, 2019
Closed
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Dec 3, 2019
@jennifer-shehane jennifer-shehane mentioned this issue Dec 4, 2019
Merged
1 task
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Dec 4, 2019
@jennifer-shehane jennifer-shehane changed the title new fontawesome spinner icon is visually clipped new fontawesome spinner icon is visually clipped in 3.8.0 prerelease Dec 4, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2019

The code for this is done in cypress-io/cypress#5870, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: ready for work The issue is reproducible and in scope and removed stage: needs review The PR code is done & tested, needs review stage: pending release labels Dec 6, 2019
@jennifer-shehane
Copy link
Member

This was released as part of 3.8.0

@jennifer-shehane jennifer-shehane removed the stage: ready for work The issue is reproducible and in scope label Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: regression A bug that didn't appear until a specific Cy version release type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
2 participants
@jennifer-shehane @kuceb