-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade font-awesome to 5+ #5822
Conversation
- replace all ‘fa’ uses with ‘fas’ or ‘far’ respectively - rename icons that required renaming - remove scss font-awesome 4 references and replace with font-awesome 5 - update npm package that is installed
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through and manually checked all the places we use icons and they all look to be good now.
* Upgrade font-awesome to 5+ - replace all ‘fa’ uses with ‘fas’ or ‘far’ respectively - rename icons that required renaming - remove scss font-awesome 4 references and replace with font-awesome 5 - update npm package that is installed * fix failing spec * include all the necssary scss * fix/improve tests * fix icon references * fix some icons Co-authored-by: Chris Breiding <[email protected]>
* Upgrade font-awesome to 5+ - replace all ‘fa’ uses with ‘fas’ or ‘far’ respectively - rename icons that required renaming - remove scss font-awesome 4 references and replace with font-awesome 5 - update npm package that is installed * fix failing spec * include all the necssary scss * fix/improve tests * fix icon references * fix some icons Co-authored-by: Chris Breiding <[email protected]>
Released in |
User facing changelog
N/A
Additional details
How has the user experience changed?
The icons should look a bit bolder.
But essentially this will be nicer for contributors, having an up to date font-awesome docs to reference and also more icons to choose from. I thought the firefox icon looked nicer especially.
Before
After
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?