Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@cypress/react): Make correct plugins for different adapters/bundlers #15299

Merged
merged 21 commits into from
Mar 5, 2021

Conversation

dmtrKovalenko
Copy link
Contributor

No description provided.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 3, 2021

Thanks for taking the time to open a PR!

@dmtrKovalenko dmtrKovalenko changed the base branch from develop to feature/cross-platform-wizard March 3, 2021 09:33
@cypress
Copy link

cypress bot commented Mar 3, 2021



Test summary

9364 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 18a7095
Started Mar 4, 2021 5:19 PM
Ended Mar 4, 2021 5:29 PM
Duration 10:35 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@dmtrKovalenko dmtrKovalenko changed the title feat: Make correct plugins for different adapters/bundlers feat(@cypress/react): Make correct plugins for different adapters/bundlers Mar 4, 2021
@dmtrKovalenko dmtrKovalenko requested a review from a team March 4, 2021 17:45
Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall one comment:
Since we are adding files in the filesystem of a user it would be valuable to add comments to the added files to explain what each file is responsible for.

Food for thoughts

npm/react/examples/nextjs/package.json Show resolved Hide resolved
@dmtrKovalenko dmtrKovalenko merged commit 0b4f76f into feature/cross-platform-wizard Mar 5, 2021
dmtrKovalenko added a commit that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants