Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-dev-server): Use viteConfig.server.port if defined #15893

Merged
merged 2 commits into from
Apr 9, 2021
Merged

fix(vite-dev-server): Use viteConfig.server.port if defined #15893

merged 2 commits into from
Apr 9, 2021

Conversation

michaelhays
Copy link
Contributor

User facing changelog

Allows the user to define a server port in their viteConfig when running the Vite dev server.

Additional details

Pretty simple/benign change -- let me know if I need to add tests or do anything else.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 8, 2021

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2021

CLA assistant check
All committers have signed the CLA.

@michaelhays michaelhays changed the title Use viteConfig.server.port if defined fix: Use viteConfig.server.port if defined Apr 8, 2021
@michaelhays michaelhays changed the title fix: Use viteConfig.server.port if defined fix(vite-dev-server): Use viteConfig.server.port if defined Apr 8, 2021
Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelhays good catch,
Your PR will help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@cypress/vite-dev-server] Ability to select different port when running dev server
3 participants