fix(vite-dev-server): only re-run tests when specs deps are updated #16215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lmiller1990
previously approved these changes
Apr 27, 2021
|
The code looks fine. I did not test it yet, so let's hold of merging until we give it a bit of a test. |
lmiller1990
reviewed
Apr 27, 2021
Probably not related to this PR but I could not test with npm/design-system. Seems the project is entirely broken. I don't know when this happened. This should be failing on CI.
|
agg23
suggested changes
Apr 27, 2021
|
The error in the screenshot above is also in develop. Not introduced here. I made an issue: #16241 |
agg23
approved these changes
Apr 28, 2021
elevatebart
pushed a commit
that referenced
this pull request
Apr 29, 2021
…16215) Co-authored-by: Lachlan Miller <[email protected]>
elevatebart
pushed a commit
that referenced
this pull request
Apr 29, 2021
…16215) Co-authored-by: Lachlan Miller <[email protected]>
elevatebart
pushed a commit
that referenced
this pull request
Apr 29, 2021
…16215) Co-authored-by: Lachlan Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Only re-runs the tests, when one of the dependency of the specs is updated, instead of every file in the project.
Additional details
Before this PR, the active spec was re-run when any file within the project, text or not, was created, modified or deleted. This could trigger some infinite loops when creating for example snapshots or screenshots. Now cypress . Slight issue, but much better