-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): only rerun if current spec/deps changed #17269
Conversation
Thanks for taking the time to open a PR!
|
@elevatebart If this is ready for review, can you provide a reproducible example to run to see this behavior? Or write an automated test to run in our repo for this? |
@jennifer-shehane I have split this PR in 2 since one can be delivered immediately and the other will be delivered with the binary #17270 |
29e3222
to
c1ed4ce
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out, works great. I wonder how we can test this kind of thing.
User facing changelog
The spec rerun only happens when the current spec is updated.
Instead of happening even when another spec gets updated.
Reproduction
cd npm/vite-dev-server
yarn cy:open