Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm/webpack-preprocessor): fix CI pipeline #17515

Merged

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Jul 29, 2021

  • Closes N/A

User facing changelog

Fix CI pipeline for webpack-preprocessor. It started consistently failing (not sure why).

Additional details

A while ago myself and Chris updated webpack-preprocessor to work with Webpack 5, but adding webpack@5 to the package.json messed up a lot of things in the monorepo.

Instead, we added this script to install webpack@5 as part of the test step for webpack-preprocessor. The main e2e tests run on webpack@5, all example projects on webpack@4. The goal was to get coverage for both Webpack versions.

The script modifies package.json, installs webpack 5, runs the tests, then reverts package.json and runs yarn install to install webpack 4 again. See that part here.

For unknown reasons, the revert part seems to not be working as expected in the last few days, and the example tests run using webpack 5, instead of the expected webpack 4. Generally the examples should work with both versions of webpack.. The problem is the example React project which has some webpack 4 specific config. Specifically, it's using create react app, which uses a deprecated node configuration.

This is no longer valid in webpack 5, which is why CI is failing. I don't why is started failing all of a sudden.

image

The solution is just to run the destructive tests that use webpack 5 as the last stage of the pipeline. I also updated the snapshots - some snapshots were actually failing, but CI was not. I think it was previously comparing webpack 4 snapshots against the webpack 5 tests, which is not correct.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 29, 2021



Test summary

18192 0 214 7Flakiness 2


Run details

Project cypress
Status Passed
Commit 3460d9d
Started Jul 29, 2021 4:40 AM
Ended Jul 29, 2021 4:52 AM
Duration 11:30 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane merged commit f82844e into develop Jul 29, 2021
tgriesser added a commit that referenced this pull request Aug 2, 2021
…ui/add-context-code-review

* unified-desktop-gui:
  feat: Structuring context & schema so it can be used on the client (#17489)
  fix: vue 3 types, beta suffix & component name (#17508)
  fix: last test skipped with top navigation and already run suite (#17498)
  chore: Update Chrome (beta) to 93.0.4577.18 (#17536)
  fix: use process.geteuid and catch uid errors in file util (#17488)
  build: make vite build strict (#17509)
  release 8.1.0
  fix(server): correctly include projectRoot when adding a CI project from GUI (#17514)
  fix(types): update cy.shadow docs url (#17506)
  chore(npm/webpack-preprocessor): fix CI pipeline (#17515)
  fix: test runner reporter performance (#17243)
  chore: release @cypress/vue-v3.0.0-beta.4
  chore: release @cypress/vite-dev-server-v2.0.3
  fix: make vite re-run on supportFile change (#17485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants