Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent vite from crashing where there are no support files or specs found #17624

Merged
merged 3 commits into from
Aug 6, 2021
Merged

fix: prevent vite from crashing where there are no support files or specs found #17624

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8721767
fix: no supportfile + no specs, vite don't crash
elevatebart Aug 5, 2021
fe5ec3e
Merge branch 'develop' into fix/no-spec-or-support-to-optimize
Aug 6, 2021
7b012b2
fix: protect startServer from undefined specs
elevatebart Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion npm/vite-dev-server/src/startServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ const resolveServerConfig = async ({ viteConfig, options }: StartDevServerOption
// Ask vite to pre-optimize all dependencies of the specs
finalConfig.optimizeDeps = finalConfig.optimizeDeps || {}

finalConfig.optimizeDeps.entries = [...options.specs.map((spec) => spec.relative), supportFile]
if (options.specs.length || supportFile) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably make sure that if specs is undefined, make sure that we don't crash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I'll add this protection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 7b012b2

finalConfig.optimizeDeps.entries = [...options.specs.map((spec) => spec.relative), supportFile]
}

debug(`the resolved server config is ${JSON.stringify(finalConfig, null, 2)}`)

Expand Down