Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info around next version, testing other projects #19157

Merged
merged 15 commits into from
Dec 2, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Nov 30, 2021

User facing changelog

n/a

Additional details

  • Created a guides directory for stuff like this so we don't have to keep tacking it on to DEPLOY.md or CONTRIBUTING.md.
  • Added a guide for determining next version and for testing other projects.
  • Moved DEPLOY.md to guides.

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 30, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 30, 2021



Test summary

18709 0 202 0Flakiness 5


Run details

Project cypress
Status Passed
Commit d4d1358
Started Dec 2, 2021 3:39 PM
Ended Dec 2, 2021 3:51 PM
Duration 11:52 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
settings_spec.js Flakiness
1 Settings > file preference panel > loads preferred editor, available editors and shows spinner
commands/navigation_spec.js Flakiness
1 src/cy/commands/navigation > #visit > window immediately resolves and doesn't reload when visiting the same URL with hashes
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review November 30, 2021 15:52
@flotwig flotwig requested a review from a team as a code owner November 30, 2021 15:52
@flotwig flotwig requested review from jennifer-shehane and ryanthemanuel and removed request for a team, jennifer-shehane and ryanthemanuel November 30, 2021 15:52
mjhenkes
mjhenkes previously approved these changes Nov 30, 2021
@flotwig flotwig requested a review from mjhenkes November 30, 2021 21:03
@@ -157,7 +153,7 @@ In the following instructions, "X.Y.Z" is used to denote the version of Cypress

11. If needed, push out any updated changes to the links manifest to [`on.cypress.io`](https://github.com/cypress-io/cypress-services/tree/develop/packages/on).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an link to how this process works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The on package has some docs, I'm actually not sure how it works with the new docs since sidebar is no longer YAML, looking into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But for now, let's not let this block this PR

@flotwig flotwig force-pushed the issue-19138-versioning-docs branch from 484f129 to c8d1632 Compare December 1, 2021 22:16
emilyrohrbough
emilyrohrbough previously approved these changes Dec 1, 2021
Copy link
Member

@emilyrohrbough emilyrohrbough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this!

tbiethman
tbiethman previously approved these changes Dec 2, 2021
@flotwig flotwig dismissed stale reviews from tbiethman and emilyrohrbough via d4d1358 December 2, 2021 15:34
@flotwig flotwig merged commit 42dfb8a into develop Dec 2, 2021
@flotwig flotwig deleted the issue-19138-versioning-docs branch December 2, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and document 'next version' testing of example apps
5 participants