fix: switching from ct to e2e (non-configured) does not go through setup #21607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
tbiethman
reviewed
May 24, 2022
|
|
||
| return true | ||
| }, | ||
| }) | ||
|
|
||
| t.field('setTestingTypeAndReconfigureProject', { |
There was a problem hiding this comment.
Yes, I'll add more comments in the future when making changes like this
tbiethman
reviewed
May 24, 2022
| sinon.stub(ctx.actions.electron, 'refreshBrowserWindow') | ||
| sinon.stub(ctx.actions.electron, 'showBrowserWindow') | ||
| await ctx.actions.project.switchTestingTypesAndRelaunch('component') | ||
| ctx.emitter.toLaunchpad() |
There was a problem hiding this comment.
Curious if we need the additional emit here (if we don't need one in the above test)?
There was a problem hiding this comment.
This was required though I couldn't track down exactly why. To be more in line with the actual behavior, I'm going to use cy.reload as that is what the ctx.actions.electron.refreshBrowserWindow() would trigger outside of a test.
tbiethman
reviewed
May 24, 2022
|
@tbiethman latest commit has no failing launchpad tests |
tbiethman
approved these changes
May 24, 2022
tgriesser
approved these changes
May 25, 2022
tgriesser
added a commit
that referenced
this pull request
May 27, 2022
…pack * develop: fix: UNIFY-1408, warnings should be nested appropriately & clearable (#21630) chore: fix unit-tests-release job (#21652) chore(deps): update dependency eventsource to v2 [security] (#21639) fix: Add hover states for test titles in reporter (#21635) docs(CONTRIBUTING): Fix link to "good first issue" for newcomers (#21614) chore: compare `cy.screenshot` images in percy (#21598) fix: switching from ct to e2e (non-configured) does not go through setup (#21607) fix: issue with compilation failures in component testing (#21599) test: fix flaky launchpad test (#21637) docs: remove gitter link in contributing guide. (#21592) fix: order projects by most recently opened (#21589) fix: prevent crash on runs visit when offline (#21618) fix: pass family parameter to connect method (#21545) chore: clean up `debug` statements in preparation for 10.0 release, add `debug` docs (#21621) chore: add regression test for ts detection (#21578)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Navigate to e2e project setup when switching from CT (configured) to e2e (not-configured) from App
Additional details
We were missing a call to
scaffoldTestingType()when switching testing types from the App. This function is what initializes e2e setup and causes the Launchpad to render the e2e setup flow. I pulled the logic out into it's own function so I could call this from within the added Launchpadproject-setup.cy.tstests to verify we are redirecting as expected.How has the user experience changed?
Before:
Screen.Recording.2022-05-23.at.3.48.49.PM.mov
After:
Screen.Recording.2022-05-23.at.3.47.20.PM.mov
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?