Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Pre-emptively preprocess support file and spec files #2184

Closed
wants to merge 18 commits into from
Closed

[WIP] Pre-emptively preprocess support file and spec files #2184

wants to merge 18 commits into from

Conversation

chrisbreiding
Copy link
Contributor

Closes #1917

@chrisbreiding
preemptively preprocess support file and spec file
f7e4e2e
@chrisbreiding
rename e2e plugin specs for easier debugging
1d8acc4
@chrisbreiding
rename e2e project to be more accurate
df04de7
@chrisbreiding
wip - handle async errors from plugins
8bd7046
@chrisbreiding
handle errors from preemptively preprocessing files
ed3a393
@chrisbreiding
only skip exiting if it’s explicitly false
0ee5c65
@chrisbreiding
move support file preprocessing later
f14bedc 
needs to happen after scaffolding
@chrisbreiding
refactor/fix preemptive preprocessing
eebd257 
- go back to events for ending/exiting run
- handle support file error when spec file gets kicked off
- handle early async error by holding reference and failing each spec immediately
@chrisbreiding
revert spec controller error handling
01ccec0 
need this in place in case of an ENOENT error from res.sendFile
@chrisbreiding
Merge branch 'develop' into issue-1917-preempty-transpile
59636ef
@chrisbreiding
Merge branch 'develop' into issue-1917-preemptively-preprocess
f511bcb
@chrisbreiding
leave file preprocessing error handling to the spec controller
272c389
@chrisbreiding
send the whole error
9cb0466
@chrisbreiding chrisbreiding self-assigned this Jul 20, 2018
@chrisbreiding chrisbreiding requested a review from brian-mann July 30, 2018 19:47
@paulfalgout paulfalgout mentioned this pull request Aug 8, 2018
Closed
@jennifer-shehane jennifer-shehane added the stage: ready for work The issue is reproducible and in scope label Jan 23, 2019
@jennifer-shehane jennifer-shehane removed the stage: ready for work The issue is reproducible and in scope label Jul 3, 2019
@jennifer-shehane
Copy link
Member

Followup on this from brian-mann

This PR had a bunch of issues we figured out at the very end
and needed a lot of restructuring
because of the way promises were being passed around
the rejections could happen at any time which would need to severe the run and cleanly exit
basically the requests currently come into the controller for the spec files
and in run mode it causes exitEarlyWithErr or whatever
and i think when we run multiple specs there’s issues with promises rejecting even though >it should continue on to other specs

@jennifer-shehane jennifer-shehane changed the title Pre-emptively preprocess support file and spec files [WIP] Pre-emptively preprocess support file and spec files Dec 18, 2019
@jennifer-shehane
Copy link
Member

Closing. From chris: This only improved performance minimally and is currently inactive.

@chrisbreiding chrisbreiding deleted the issue-1917-preemptively-preprocess branch April 5, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann Awaiting requested review from brian-mann

Assignees

@chrisbreiding chrisbreiding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance: preemptively transpile 'the next spec file'
2 participants
@chrisbreiding @jennifer-shehane