chore: do not rely on transitive dep. from npm/react #22914
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
N/A
Additional details
I removed an unused dependency from
npm/react
,cypress-plugin-snapshots
. Surprisingly, things broke. It turned out we were relying on a transitive dependency, which isn't ideal.cypress-plugin-snapshots
->socket.io-client
->engine.io-client
I added the required dependency to
app
andlaunchpad
. This still isn't ideal. We dopatch-package
insocket
, as well asnohoist
- I don't think there should be any socket.io related dependencies at the top levelnode_modules
at all. I am unsure why there are there at all. I could not figure out why after a whole day, so I'm leaving it here - this is at least better than relying on a dependency's dependency, especially one that isn't even inpackages
.Steps to test
Observe CI passes - this confirms nothing is broken.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?