Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not rely on transitive dep. from npm/react #22914

Closed

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Jul 25, 2022

  • Closes N/A

User facing changelog

N/A

Additional details

I removed an unused dependency from npm/react, cypress-plugin-snapshots. Surprisingly, things broke. It turned out we were relying on a transitive dependency, which isn't ideal.

cypress-plugin-snapshots -> socket.io-client -> engine.io-client

I added the required dependency to app and launchpad. This still isn't ideal. We do patch-package in socket, as well as nohoist - I don't think there should be any socket.io related dependencies at the top level node_modules at all. I am unsure why there are there at all. I could not figure out why after a whole day, so I'm leaving it here - this is at least better than relying on a dependency's dependency, especially one that isn't even in packages.

Steps to test

Observe CI passes - this confirms nothing is broken.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@lmiller1990 lmiller1990 requested a review from a team as a code owner July 25, 2022 09:16
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 25, 2022

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 requested review from a team, chrisbreiding and AtofStryker and removed request for a team, chrisbreiding and AtofStryker July 25, 2022 09:16
@lmiller1990 lmiller1990 marked this pull request as draft July 25, 2022 11:36
@lmiller1990 lmiller1990 removed the request for review from a team July 25, 2022 11:36
@lmiller1990
Copy link
Contributor Author

lmiller1990 commented Jul 25, 2022

I think I can do this as the same time as Vite 3: #22915 Let's see!

@lmiller1990
Copy link
Contributor Author

@lmiller1990 lmiller1990 mentioned this pull request Jul 26, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant