fix: performance regression due to enabling ScopeMemoryCachePerContext #28327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
commented
Nov 13, 2023
1 flaky test on run #52276 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #28327 ↗︎
mschile
reviewed
Nov 14, 2023
mschile
reviewed
Nov 14, 2023
mschile
approved these changes
Nov 14, 2023
ryanthemanuel
commented
Nov 14, 2023
| @@ -53,7 +53,7 @@ describe('src/cypress/dom/visibility', () => { | |||
| expect(fn()).to.be.true | |||
| }) | |||
|
|
|||
| it('returns false window and body > window height', () => { | |||
| it('returns false if window and body < window height', () => { | |||
There was a problem hiding this comment.
what this title wrong before?
There was a problem hiding this comment.
Yes. Things should only be scrollable if they're > than the height not <.
There was a problem hiding this comment.
Basically this is the opposite of line 45.
chrisbreiding
approved these changes
Nov 14, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This fix basically reverses the commit that was done to try and prevent the font flooding. The only addition is a change to ensure that #28150 stays fixed (namely this commit).
Steps to test
n/a
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?